test: fix flaky test-single-executable-application-empty #61616
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
test/sea/test-single-executable-application-empty.jsProblem
The test was flaky on Windows because postject WASM could abort intermittently
during SEA build with an error like "Aborted(). Build with -sASSERTIONS for
more info."
This is an infrastructure issue rather than a Node.js code issue.
Solution
Modified
buildSEAintest/common/sea.jsto handle build failures gracefully:verifyWorkflowis false, skip the test on build failuresverifyWorkflowis true, throw a descriptive error that can be caughtUpdated the test to catch
SEA build failederrors and skip accordingly.Verification
Verified with
python3 tools/test.py --repeat 100without failures.Refs: nodejs/reliability#1450