repl: fix flaky test-repl-programmatic-history #61614
Open
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
mcollina
force-pushed
the
fix-flaky-test-repl-programmatic-history
branch
from
56947c3 to
e2afc62
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61614 +/- ##
==========================================
- Coverage 89.76% 89.75% -0.02%
==========================================
Files 673 674 +1
Lines 203944 204088 +144
Branches 39191 39238 +47
==========================================
+ Hits 183080 183171 +91
- Misses 13194 13238 +44
- Partials 7670 7679 +9
🚀 New features to boost your workflow:
|
lpinca
reviewed
Feb 2, 2026
lib/internal/repl/history.js
Outdated
| debug('Error closing history file:', err); | ||
| } | ||
| } | ||
| this[kContext].emit('historyHandleClosed'); |
lpinca
reviewed
Feb 2, 2026
lib/repl.js
Outdated
| if (this.terminal && this.historyManager?.closeHandle && !this._historyHandleClosed) { | ||
| this._historyHandleClosed = true; | ||
| this.historyManager.closeHandle().then(() => { | ||
| process.nextTick(() => super.close()); |
Member
There was a problem hiding this comment.
Is process.nextTick() needed here?
Member
Author
There was a problem hiding this comment.
I generically prefer this to exit the promise chain. It's probably safe to avoid here
The test was flaky because the FileHandle for the history file could be garbage collected before being explicitly closed, causing ERR_INVALID_STATE errors when the handle was already closed by the GC finalizer. This fix adds an explicit closeHandle() method to ReplHistory and ensures that REPLServer.close() waits for the history file handle to be properly closed before completing the close operation. Refs: nodejs/reliability#1450
mcollina
force-pushed
the
fix-flaky-test-repl-programmatic-history
branch
from
e2afc62 to
d715296
Compare
lpinca
approved these changes
Feb 2, 2026
github-actions
bot
removed
the
request-ci
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes flaky test
test/parallel/test-repl-programmatic-history.js.Problem
The test was flaky because the FileHandle for the history file could be garbage collected before being explicitly closed, causing
ERR_INVALID_STATEerrors when the handle was already closed by the GC finalizer.Solution
closeHandle()method toReplHistoryclassREPLServer.close()to wait for the history file handle to be properly closed before completing the close operationVerification
Verified with
python3 tools/test.py --repeat 1000 test/parallel/test-repl-programmatic-history.js- all 1000 runs passed with 0 failures.Refs: nodejs/reliability#1450