url: update ada to v3.4.2 and support unicode 17 #61593
Merged
+1,847
−1,840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
anonrig
force-pushed
the
yagiz/update-ada-v-3-4-2
branch
from
bb26dde to
fe29dec
Compare
Contributor
|
FWIW it doesn't require a manual PR, it's certainly fine to push a fixup commit to the bot PR, but a manual PR also works |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61593 +/- ##
==========================================
- Coverage 89.79% 89.77% -0.03%
==========================================
Files 673 673
Lines 203852 203852
Branches 39181 39182 +1
==========================================
- Hits 183044 182998 -46
- Misses 13143 13189 +46
Partials 7665 7665 🚀 New features to boost your workflow:
|
aduh95
approved these changes
Jan 30, 2026
aduh95
added
author ready
gurgunday
approved these changes
Jan 30, 2026
github-actions
bot
removed
the
request-ci
Collaborator
RafaelGSS
approved these changes
Jan 30, 2026
anonrig
added
the
commit-queue
cjihrig
approved these changes
Jan 31, 2026
MattiasBuelens
approved these changes
Feb 1, 2026
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 356e4ae |
anonrig
added
the
notable-change
Contributor
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
aduh95
pushed a commit
that referenced
this pull request
Feb 2, 2026
PR-URL: #61593 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
nodejs-github-bot
added a commit
that referenced
this pull request
Feb 2, 2026
Notable changes: async_hooks: * (SEMVER-MINOR) add trackPromises option to createHook() (Joyee Cheung) #61415 src: * improve textEncoder encode performance with simdutf (Mert Can Altin) #61496 stream: * (SEMVER-MINOR) add bytes() method to stream/consumers (wantaek) #60426 test_runner: * (SEMVER-MINOR) add env option to run function (Ethan Arrowood) #61367 url: * update ada to v3.4.2 and support unicode 17 (Yagiz Nizipli) #61593 PR-URL: #61635
aduh95
pushed a commit
that referenced
this pull request
Feb 2, 2026
PR-URL: #61593 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
aduh95
added a commit
that referenced
this pull request
Feb 2, 2026
Notable changes: async_hooks: * (SEMVER-MINOR) add `trackPromises` option to `createHook()` (Joyee Cheung) #61415 net: * (SEMVER-MINOR) add `setTOS` and `getTOS` to `Socket` (Amol Yadav) #61503 src: * (SEMVER-MINOR) add initial support for ESM in embedder API (Joyee Cheung) #61548 * improve `TextEncoder` encode performance with `simdutf` (Mert Can Altin) #61496 stream: * (SEMVER-MINOR) add `bytes()` method to `node:stream/consumers` (wantaek) #60426 test_runner: * (SEMVER-MINOR) add `env` option to `run` function (Ethan Arrowood) #61367 url: * update Ada to v3.4.2 and support Unicode 17 (Yagiz Nizipli) #61593 PR-URL: #61635
aduh95
added a commit
that referenced
this pull request
Feb 2, 2026
Notable changes: async_hooks: * (SEMVER-MINOR) add `trackPromises` option to `createHook()` (Joyee Cheung) #61415 net: * (SEMVER-MINOR) add `setTOS` and `getTOS` to `Socket` (Amol Yadav) #61503 src: * (SEMVER-MINOR) add initial support for ESM in embedder API (Joyee Cheung) #61548 * improve `TextEncoder` encode performance with `simdutf` (Mert Can Altin) #61496 stream: * (SEMVER-MINOR) add `bytes()` method to `node:stream/consumers` (wantaek) #60426 test_runner: * (SEMVER-MINOR) add `env` option to `run` function (Ethan Arrowood) #61367 url: * update Ada to v3.4.2 and support Unicode 17 (Yagiz Nizipli) #61593 PR-URL: #61635
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required manual pull-request since remaining failed web-platform tests are now passing. cc @nodejs/url