-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
test: unify assertSnapshot common patterns #61590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
legendecas
wants to merge
3
commits into
nodejs:main
Choose a base branch
from
legendecas:test-snapshot-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+851
−666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3e5123 to
b83fca8
Compare
Unifes assertSnapshot common patterns like platform specific path separators, line ending, line trailing spaces, Node.js version strings, and pids in warning messages.
b83fca8 to
f67151d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61590 +/- ##
==========================================
- Coverage 89.76% 89.76% -0.01%
==========================================
Files 673 673
Lines 203840 203852 +12
Branches 39187 39185 -2
==========================================
+ Hits 182979 182985 +6
- Misses 13184 13190 +6
Partials 7677 7677 🚀 New features to boost your workflow:
|
aduh95
reviewed
Jan 30, 2026
MoLow
approved these changes
Feb 1, 2026
aduh95
approved these changes
Feb 2, 2026
Collaborator
Collaborator
3da8d5c to
790bc01
Compare
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifes
assertSnapshotcommon patterns like platform specific pathseparators, line ending, line trailing spaces, Node.js version strings,
and pids in warning messages.
Ultimately, it should be not necessary to customize the ad-hoc snapshot
patterns.