-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
doc: update server.dropMaxConnection link
#61584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
| 1. If the process is not running in cluster mode, Node.js will close the connection. | ||
|
|
||
| 2. If the process is running in cluster mode, Node.js will, by default, route the connection to another worker process. To close the connection instead, set \[`server.dropMaxConnection`]\[] to `true`. | ||
| 2. If the process is running in cluster mode, Node.js will, by default, route the connection to another worker process. To close the connection instead, set [`server.dropMaxConnection`][] to `true`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
| 2. If the process is running in cluster mode, Node.js will, by default, route the connection to another worker process. To close the connection instead, set [`server.dropMaxConnection`][] to `true`. | |
| 2. If the process is running in cluster mode, Node.js will, by default, route the | |
| connection to another worker process. To close the connection instead, set | |
| [`server.dropMaxConnection`][] to `true`. |
pimterry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'd normally land this now since this it's all good to go, but there's an open nit comment here. @samuel871211 that's a totally optional suggestion, so you can either do it if you have a sec or not if you just want to get this done quickly - just let us know and then this can be merged.
No description provided.