net: add setTypeOfService and getTypeOfService to Socket #61503

amyssnippet · 2026-01-24T11:11:33Z

this PR implements socket.setTypeOfService(tos) and socket.getTypeOfService() in net.Socket. it needed this to support DSCP tagging (QoS) for traffic prioritization, which wasn't previously exposed in the JS API. for the implementation:

I added the logic in tcp_wrap.cc to attempt IP_TOS first, and fallback to IPV6_TCLASS if that fails. This handles both IPv4 and IPv6 sockets automatically without needing a separate flag.
Windows returns UV_ENOSYS for now since the headers/implementation differ there.
Added a new test file (test-net-socket-tos.js) to verify input validation and ensure the values are actually set on supported platforms.

Fixes: #61489

nodejs-github-bot · 2026-01-24T11:11:39Z

Review requested:

@nodejs/net

mcollina

Good work. Can you add the documentation?

test/parallel/test-net-socket-tos.js

doc/api/net.md

src/tcp_wrap.cc

test/parallel/test-net-socket-tos.js

amyssnippet · 2026-01-24T16:03:04Z

Thanks @mcollina , is this ready to be merged? Please let me know if there is anything else you need me to adjust.

src/tcp_wrap.cc

nodejs-github-bot · 2026-01-25T07:11:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71012/

ronag · 2026-01-25T10:53:10Z

@mcollina I'm confused by the CI failures. Any ideas? Or just flaky?

nodejs-github-bot · 2026-01-31T02:05:35Z

Commit Queue failed

- Loading data for nodejs/node/pull/61503
✔  Done loading data for nodejs/node/pull/61503
----------------------------------- PR info ------------------------------------
Title      net: add setTypeOfService and getTypeOfService to Socket (#61503)
Author     Amol Yadav  <amyssnipet@yahoo.com> (@amyssnippet, first-time contributor)
Branch     amyssnippet:fix/61489 -> nodejs:main
Labels     c++, semver-minor, lib / src, author ready, commit-queue-squash
Commits    34
 - net: add setTOS and getTOS to Socket
 - added doc
 - fixed some lint issues
 - already complete with validation and platform specific tests
 - added: REPLACEME
 - common.mustCall used
 - undo: unrelated header was removed irrelevantly
 - fix: resolve windows compilation and linter issues
 - rollback to tcp only
 - fix: ensure getTOS returns numeric default when handle lacks getTOS
 - fix: handle setTOS errors in afterConnect and use options.tos
 - fix: capture errno immediately after getsockopt failures
 - fix: use correct length type for Windows getsockopt and fix DSCP mask…
 - fix: validate options.tos in constructor
 - fix: use validateInt32 for options.tos and standardize GetTOS error
 - fix: remove unused errno_val in TCPWrap::GetTOS POSIX path
 - test: add boundary value assertions for TOS
 - test: add pre-connect TOS caching test
 - doc: add notes for setTOS and getTOS about pre-connect caching and OS…
 - fix: import UV_EBADF and remove duplicate mask declaration
 - fix: update TOS cache when handle lacks setTOS
 - doc: clarify pre-connect TOS test comment
 - refined: comments
 - doc: remove prohibited 'Note that' phrases
 - fix: reorder includes for Windows compatibility and add missing POSIX…
 - fix: resolve windows header order and doc lint errors
 - feat: rename setTOS/getTOS to setTypeOfService/getTypeOfService for A…
 - fix: update internal handle calls to use new TypeOfService method names
 - win vs2022 ci fix
 - added: todo for libuv api
 - fixed:win vs2022 lint ci
 - feat: rename C++ methods from SetTOS/GetTOS to SetTypeOfService/GetTy…
 - docs: update net.md for typeOfService option and fix lib/net.js const…
 - Apply suggestions from code review
Committers 2
 - Amol Yadav <amyssnipet@yahoo.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/61503
Fixes: https://github.com/nodejs/node/issues/61489
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61503
Fixes: https://github.com/nodejs/node/issues/61489
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 24 Jan 2026 11:11:33 GMT
   ✔  Approvals: 3
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/61503#pullrequestreview-3731022920
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/61503#pullrequestreview-3730004460
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/61503#pullrequestreview-3711651185
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-01-30T23:57:17Z: https://ci.nodejs.org/job/node-test-pull-request/71128/
- Querying data for job/node-test-pull-request/71128/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ⚠  PR author is a new contributor: @amyssnippet(amyssnipet@yahoo.com)
   ⚠  - commit d53c0157fc93 is authored by ronagy@icloud.com
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/21536896438

juanarbol · 2026-01-31T03:30:26Z

Apparently commit-queue job is failing because of d53c015, which was committed by somebody else. And triggered because a new contributor.

Refs: https://github.com/nodejs/node-core-utils/blob/19b468ad088a8200eabdc94a96f58a6027e2fc11/lib/pr_checker.js#L84

amyssnippet · 2026-01-31T03:39:21Z

Apparently commit-queue job is failing because of d53c015, which was committed by somebody else. And triggered because a new contributor.

Refs: https://github.com/nodejs/node-core-utils/blob/19b468ad088a8200eabdc94a96f58a6027e2fc11/lib/pr_checker.js#L84

so what should i do now?? @ronag has did that commit himself and he is a member too

mcollina

lgtm

amyssnippet · 2026-02-02T06:23:44Z

@ronag and @mcollina , why the merging failed??

ronag · 2026-02-02T06:24:54Z

No idea. Not familiar with that error or how to fix it.

amyssnippet · 2026-02-02T06:30:37Z

i guess @juanarbol told it here

Apparently commit-queue job is failing because of d53c015, which was committed by somebody else. And triggered because a new contributor.

Refs: https://github.com/nodejs/node-core-utils/blob/19b468ad088a8200eabdc94a96f58a6027e2fc11/lib/pr_checker.js#L84

ronag · 2026-02-02T07:16:59Z

Still not familiar with it nor do I understand how to fix it. Hopefully someone else will jump in.

nodejs-github-bot · 2026-02-02T11:09:34Z

Commit Queue failed

- Loading data for nodejs/node/pull/61503
✔  Done loading data for nodejs/node/pull/61503
----------------------------------- PR info ------------------------------------
Title      net: add setTypeOfService and getTypeOfService to Socket (#61503)
Author     Amol Yadav  <amyssnipet@yahoo.com> (@amyssnippet, first-time contributor)
Branch     amyssnippet:fix/61489 -> nodejs:main
Labels     c++, semver-minor, lib / src, author ready, commit-queue-squash
Commits    34
 - net: add setTOS and getTOS to Socket
 - added doc
 - fixed some lint issues
 - already complete with validation and platform specific tests
 - added: REPLACEME
 - common.mustCall used
 - undo: unrelated header was removed irrelevantly
 - fix: resolve windows compilation and linter issues
 - rollback to tcp only
 - fix: ensure getTOS returns numeric default when handle lacks getTOS
 - fix: handle setTOS errors in afterConnect and use options.tos
 - fix: capture errno immediately after getsockopt failures
 - fix: use correct length type for Windows getsockopt and fix DSCP mask…
 - fix: validate options.tos in constructor
 - fix: use validateInt32 for options.tos and standardize GetTOS error
 - fix: remove unused errno_val in TCPWrap::GetTOS POSIX path
 - test: add boundary value assertions for TOS
 - test: add pre-connect TOS caching test
 - doc: add notes for setTOS and getTOS about pre-connect caching and OS…
 - fix: import UV_EBADF and remove duplicate mask declaration
 - fix: update TOS cache when handle lacks setTOS
 - doc: clarify pre-connect TOS test comment
 - refined: comments
 - doc: remove prohibited 'Note that' phrases
 - fix: reorder includes for Windows compatibility and add missing POSIX…
 - fix: resolve windows header order and doc lint errors
 - feat: rename setTOS/getTOS to setTypeOfService/getTypeOfService for A…
 - fix: update internal handle calls to use new TypeOfService method names
 - win vs2022 ci fix
 - added: todo for libuv api
 - fixed:win vs2022 lint ci
 - feat: rename C++ methods from SetTOS/GetTOS to SetTypeOfService/GetTy…
 - docs: update net.md for typeOfService option and fix lib/net.js const…
 - Apply suggestions from code review
Committers 2
 - Amol Yadav <amyssnipet@yahoo.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/61503
Fixes: https://github.com/nodejs/node/issues/61489
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61503
Fixes: https://github.com/nodejs/node/issues/61489
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 24 Jan 2026 11:11:33 GMT
   ✔  Approvals: 3
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/61503#pullrequestreview-3736689951
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/61503#pullrequestreview-3737494805
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/61503#pullrequestreview-3711651185
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-01-31T02:05:35Z: https://ci.nodejs.org/job/node-test-pull-request/71128/
- Querying data for job/node-test-pull-request/71128/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ⚠  PR author is a new contributor: @amyssnippet(amyssnipet@yahoo.com)
   ⚠  - commit d53c0157fc93 is authored by ronagy@icloud.com
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/21587645333

ronag · 2026-02-02T11:18:35Z

@aduh95 same failure as before " PR author is a new contributor: @amyssnippet(amyssnipet@yahoo.com)"

amyssnippet · 2026-02-02T11:19:17Z

it looks like the commit queue is still failing because of mixed authorship and i am a new contributor. could anyone please manually land this PR as the bot seems unable to handle the squash in this scenario

aduh95 · 2026-02-02T11:23:33Z

Landed in 5212c07

amyssnippet · 2026-02-02T11:42:10Z

thanks every maintainer here to help me contribute to the nodejs community

PR-URL: #61503 Fixes: #61489 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Notable changes: async_hooks: * (SEMVER-MINOR) add `trackPromises` option to `createHook()` (Joyee Cheung) #61415 net: * (SEMVER-MINOR) add `setTOS` and `getTOS` to `Socket` (Amol Yadav) #61503 src: * (SEMVER-MINOR) add initial support for ESM in embedder API (Joyee Cheung) #61548 * improve `TextEncoder` encode performance with `simdutf` (Mert Can Altin) #61496 stream: * (SEMVER-MINOR) add `bytes()` method to `node:stream/consumers` (wantaek) #60426 test_runner: * (SEMVER-MINOR) add `env` option to `run` function (Ethan Arrowood) #61367 url: * update Ada to v3.4.2 and support Unicode 17 (Yagiz Nizipli) #61593 PR-URL: #61635

net: add setTOS and getTOS to Socket

eb53d09

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 24, 2026

mcollina requested changes Jan 24, 2026

View reviewed changes

test/parallel/test-net-socket-tos.js Outdated Show resolved Hide resolved

mcollina requested a review from ronag January 24, 2026 13:16

mcollina added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 24, 2026

amyssnippet added 3 commits January 24, 2026 19:08

added doc

9e7a183

fixed some lint issues

14b3fb0

already complete with validation and platform specific tests

f339cd0

amyssnippet requested a review from mcollina January 24, 2026 13:41

amyssnippet mentioned this pull request Jan 24, 2026

socket.setTOS #61489

Closed

mcollina requested changes Jan 24, 2026

View reviewed changes

doc/api/net.md Outdated Show resolved Hide resolved

doc/api/net.md Outdated Show resolved Hide resolved

src/tcp_wrap.cc Show resolved Hide resolved

test/parallel/test-net-socket-tos.js Outdated Show resolved Hide resolved

amyssnippet added 2 commits January 24, 2026 19:52

added: REPLACEME

d32f212

common.mustCall used

71ecbd7

amyssnippet requested a review from mcollina January 24, 2026 14:34

ronag approved these changes Jan 24, 2026

View reviewed changes

ronag reviewed Jan 24, 2026

View reviewed changes

src/tcp_wrap.cc Outdated Show resolved Hide resolved

ronag mentioned this pull request Jan 24, 2026

Type of Service (IP prioritization) nodejs/undici#4765

Open

undo: unrelated header was removed irrelevantly

c0407b2

amyssnippet force-pushed the fix/61489 branch from 42d5142 to c0407b2 Compare January 25, 2026 05:03

amyssnippet requested a review from ronag January 25, 2026 05:05

ronag approved these changes Jan 25, 2026

View reviewed changes

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2026

ronag mentioned this pull request Jan 25, 2026

Feature Request - Allow setting ToS on socket (rather; wrap getNativeHandle() and let you apply whatever options you wish) uNetworking/uWebSockets.js#1205

Open

richardlau added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 31, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 31, 2026

amyssnippet requested review from mcollina and ronag January 31, 2026 09:46

amyssnippet mentioned this pull request Jan 31, 2026

test-repl-programmatic-history is flaky #61578

Open

mcollina approved these changes Feb 1, 2026

View reviewed changes

ronag approved these changes Feb 2, 2026

View reviewed changes

ronag mentioned this pull request Feb 2, 2026

2026-02-03, Version 25.6.0 (Current) #61635

Open

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 2, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 2, 2026

aduh95 merged commit 5212c07 into nodejs:main Feb 2, 2026
95 of 96 checks passed

aduh95 pushed a commit that referenced this pull request Feb 2, 2026

net: add setTOS and getTOS to Socket

4cf94fa

PR-URL: #61503 Fixes: #61489 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Uh oh!

net: add setTypeOfService and getTypeOfService to Socket #61503

net: add setTypeOfService and getTypeOfService to Socket #61503

Conversation

amyssnippet commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 24, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amyssnippet commented Jan 24, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 25, 2026

Uh oh!

ronag commented Jan 25, 2026

Uh oh!

nodejs-github-bot commented Jan 31, 2026

Uh oh!

juanarbol commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amyssnippet commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

amyssnippet commented Feb 2, 2026

Uh oh!

ronag commented Feb 2, 2026

Uh oh!

amyssnippet commented Feb 2, 2026

Uh oh!

ronag commented Feb 2, 2026

Uh oh!

nodejs-github-bot commented Feb 2, 2026

Uh oh!

ronag commented Feb 2, 2026

Uh oh!

amyssnippet commented Feb 2, 2026

Uh oh!

Uh oh!

aduh95 commented Feb 2, 2026

Uh oh!

amyssnippet commented Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

amyssnippet commented Jan 24, 2026 •

edited

Loading

juanarbol commented Jan 31, 2026 •

edited

Loading

amyssnippet commented Jan 31, 2026 •

edited

Loading