[v24.x backport] build: test on Python 3.14 #61370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
aduh95
reviewed
Jan 13, 2026
aduh95
approved these changes
Jan 14, 2026
avivkeller
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
richardlau
approved these changes
Jan 16, 2026
Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: nodejs#59983 Backport-PR-URL: nodejs#61370 Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Refs: nodejs#60874
aduh95
force-pushed
the
backport-59983-to-v24.x
branch
from
a0f4121 to
4606233
Compare
Contributor
|
Landed in 4606233 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v24.x-staging #61370 +/- ##
=================================================
+ Coverage 90.05% 90.07% +0.01%
=================================================
Files 663 665 +2
Lines 198499 199008 +509
Branches 38810 38909 +99
=================================================
+ Hits 178768 179247 +479
- Misses 12112 12133 +21
- Partials 7619 7628 +9 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python v3.14 -- October 7th
PR-URL: #59983
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Stefan Stojanovic stefan.stojanovic@janeasystems.com
Reviewed-By: Stewart X Addison sxa@redhat.com
Refs: #60874
Situation
Node.js 24.x (Active LTS) build fails with Python 3.14.
Python 3.14 is:
py install defaultChange
Backports #59983 (commit 8bc7dfd) to v24.x branch.
The commit message from the backport should be modified, removing the outdated "release candidate 3" text. It is currently:
Python 3.14 was released as GA on 2025-10-07 and is therefore no longer pre-release.
https://www.python.org/downloads/release/python-3140rc3/ states:
Although the PR title #59983 was edited to remove the reference to "release candidate 3", the single commit it contained (109d743) retained the text "release candidate 3".
Use of the GitHub Actions' actions/setup-python flag setting
allow-prereleases: trueis removed from the backport as suggested by @richardlau in #60874 and explicitly requested by @aduh95. Since the workflow usesPYTHON_VERSION: '3.14'and this is a released Python version, the flag is not necessary.