Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61356 +/- ##
==========================================
- Coverage 88.54% 88.51% -0.03%
==========================================
Files 704 704
Lines 208793 208793
Branches 40307 40303 -4
==========================================
- Hits 184866 184817 -49
- Misses 15913 15962 +49
Partials 8014 8014 🚀 New features to boost your workflow:
|
Author
|
@LiviaMedeiros Hi, I opened a PR for this issue. The build and tests appear to be passing. Would you mind taking a look? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Summary
Motivation
Snapshot normalization used raw cwd/path string replacement, which can
corrupt non-path tokens (e.g. URLs) when cwd matches substrings like
"/node". This keeps normalization cwd-agnostic by stripping only true
path prefixes and handling file:// forms without touching other schemes.
Changes
test/common/assertSnapshot.jsfile:////by consuming the extra boundary slash when replacement is emptytest/parallel/test-node-output-*.mjstest/parallel/test-cli-permission-deny-fs.jstest/es-module/test-esm-import-meta.mjstest/parallel/test-assert-snapshot-transform-project-root.jsTests
python3 tools/test.py -m release test/parallel/test-assert-snapshot-transform-project-root.jspython3 tools/test.py -m release test/parallel/test-node-output-*.mjspython3 tools/test.py -m release test/es-module/test-esm-import-meta.mjs