[v24.x backport] build: expose libplatform symbols in shared libnode#61306
Closed
jeroen wants to merge 1 commit intonodejs:v24.x-stagingfrom
Closed
[v24.x backport] build: expose libplatform symbols in shared libnode#61306jeroen wants to merge 1 commit intonodejs:v24.x-stagingfrom
jeroen wants to merge 1 commit intonodejs:v24.x-stagingfrom
Conversation
This requires setting BUILDING_V8_PLATFORM_SHARED to expose the public symbols since we build with hidden visibility by default. PR-URL: nodejs#61144 Fixes: nodejs#61102 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Member
|
Thanks for the PR but since it cherry-picks cleanly to v24.x-staging, this is not necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit:
PR-URL: #61144
Fixes: #61102
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Chengzhong Wu legendecas@gmail.com
Reviewed-By: Richard Lau richard.lau@ibm.com