doc: document process.moduleLoadList by Xstoudi · Pull Request #61276 · nodejs/node

Xstoudi · 2026-01-04T20:35:25Z

process.moduleLoadList was added in the early days but never documented

nodejs-github-bot · 2026-01-04T20:35:30Z

Review requested:

@nodejs/loaders
@nodejs/startup

codecov · 2026-01-04T21:59:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (282d30e) to head (1080338).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61276      +/-   ##
==========================================
- Coverage   88.53%   88.52%   -0.02%     
==========================================
  Files         704      704              
  Lines      208759   208750       -9     
  Branches    40277    40279       +2     
==========================================
- Hits       184825   184790      -35     
- Misses      15934    15971      +37     
+ Partials     8000     7989      -11

Files with missing lines	Coverage Δ
lib/internal/bootstrap/realm.js	`96.29% <100.00%> (+0.29%)`	⬆️

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lib/internal/bootstrap/realm.js

avivkeller · 2026-01-05T17:21:15Z

I'm okay with the doc changes, but any changes to functionality should be in a separate PR, IMO

process.moduleLoadList was provided as-is instead of a copy of it Refs: nodejs#41233 Refs: nodejs#61276

process.moduleLoadList was added in the early days but never documented Fixes: nodejs#41233

process.moduleLoadList was provided as-is instead of a copy of it Refs: nodejs#41233 Refs: nodejs#61276

Xstoudi · 2026-01-05T18:03:15Z

Doc change is here, code change moved to this draft: #61287
I'll remove the draft state once this one is merged and other branch rebased.

Sorry for the commit soup

doc/api/process.md

joyeecheung · 2026-01-06T11:00:30Z

doc/api/process.md

+import { moduleLoadList } from 'node:process';
+
+console.log(moduleLoadList);
+// ['Internal Binding builtins', 'Internal Binding module_wrap', 'Internal Binding errors', ...]


I think the current shape of the API isn't very suitable to be a proper, public API - for example the types and the module names are mixed into a string, and there are no guarantees about when the types would change or what types there are; the names of the modules are also highly volatile and cannot be reliably depended on, and this might backfire if users start to claim changes to this array - removing/adding internal modules or their types - are supposed to be semver-major, just because this is a documented API.

IMO a documented version of this should either expose enum-like constants for types, and/or just filter out all the internals in the array.

Thanks for the review!

I also feel like it would be better to have something like { type: 'INTERNAL' | 'BUILTIN', name: string } in this list instead of concatened strings albeit as far as I understand, it wouldn't fix the concern regarding the removing/adding of internal modules being claimed as major changes. Or am I mistaken here?

Filtering out the internals is also a good option: tests do not rely on them being present anyway. Could this list become as list of builtins name in the form of ['foo', 'bar', 'baz'] instead of ['Internal Binding builtins', 'Internal Binding module_wrap', 'NativeModule foo', 'NativeModule bar', 'NativeModule baz'] ?

What's option seems the safest to you regarding the concerns you mentionned?

Third option: leave is as is, untouched and undocumented on purpose.

cc @aduh95 (#41233 (comment)) – don't know whether you still have an opinion?

FWIW it wasn't added in #24775, as suggested in the changelog in this PR this dates back to the 0.x days when everything got exposed on process without a lot of thoughts into what's public and what's internal.

Also I think my personal preference would be: a separate list of strings with public modules only, and document that instead > leave it as is > a separate list of objects with enum + names (including internals) > document the current API

Hardanish-Singh · 2026-01-06T15:09:58Z

doc/api/process.md

+* Type: {string\[]}
+
+The `process.moduleLoadList` property returns an array of internal bindings and core modules that
+were loaded during the current Node.js process execution.


Small wording nit: "process execution" feels slightly redundant. "during the current process" might be cleaner.

that were loaded during the current Node.js process execution.

that were loaded during the current process.

Hardanish-Singh · 2026-01-06T15:15:59Z

doc/api/process.md

+
+* Type: {string\[]}
+
+The `process.moduleLoadList` property returns an array of internal bindings and core modules that


Nit: Since the documentation text specifically refers to process.moduleLoadList, should the example use process.moduleLoadList directly instead of destructuring?

import process from 'node:process'; console.log(process.moduleLoadList);

#61276 (comment)

Add a new `process.loadedModules` property that returns an array of public core module names that have been loaded during the current Node.js process execution. This provides a cleaner, documented API for accessing loaded module information compared to the undocumented `process.moduleLoadList`. Fixes: nodejs#41233 Refs: nodejs#61276

Xstoudi · 2026-01-09T21:45:10Z

Closed in favor of #61330

Add a new `process.loadedModules` property that returns an array of public core module names that have been loaded during the current Node.js process execution. This provides a cleaner, documented API for accessing loaded module information compared to the undocumented `process.moduleLoadList`. Fixes: nodejs#41233 Refs: nodejs#61276

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 4, 2026

Xstoudi force-pushed the fix/module-load-list branch from bcf2e77 to 984da23 Compare January 4, 2026 20:35

Renegade334 reviewed Jan 5, 2026

View reviewed changes

lib/internal/bootstrap/realm.js Outdated Show resolved Hide resolved

lib/internal/bootstrap/realm.js Outdated Show resolved Hide resolved

lib/internal/bootstrap/realm.js Outdated Show resolved Hide resolved

Xstoudi added a commit to Xstoudi/node that referenced this pull request Jan 5, 2026

lib: make process.moduleLoadList a copy of the internal value

30bec50

process.moduleLoadList was provided as-is instead of a copy of it Refs: nodejs#41233 Refs: nodejs#61276

Xstoudi force-pushed the fix/module-load-list branch from e3e19f1 to 3e1972e Compare January 5, 2026 17:57

doc: document process.moduleLoadList

b061243

process.moduleLoadList was added in the early days but never documented Fixes: nodejs#41233

Xstoudi force-pushed the fix/module-load-list branch from ea0665b to b061243 Compare January 5, 2026 17:57

Xstoudi added a commit to Xstoudi/node that referenced this pull request Jan 5, 2026

lib: make process.moduleLoadList a copy of the internal value

8a06cda

process.moduleLoadList was provided as-is instead of a copy of it Refs: nodejs#41233 Refs: nodejs#61276

Xstoudi added a commit to Xstoudi/node that referenced this pull request Jan 5, 2026

lib: make process.moduleLoadList a copy of the internal value

677b094

process.moduleLoadList was provided as-is instead of a copy of it Refs: nodejs#41233 Refs: nodejs#61276

Xstoudi changed the title ~~lib,doc: make process.moduleLoadList immutable and document it~~ doc: document process.moduleLoadList Jan 5, 2026

Xstoudi mentioned this pull request Jan 5, 2026

lib: make process.moduleLoadList a copy of the internal value #61287

Closed

Renegade334 reviewed Jan 5, 2026

View reviewed changes

doc/api/process.md Outdated Show resolved Hide resolved

Renegade334 added doc Issues and PRs related to the documentations. and removed lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 5, 2026

wrong terminology

635af17

aduh95 approved these changes Jan 5, 2026

View reviewed changes

Renegade334 approved these changes Jan 5, 2026

View reviewed changes

Renegade334 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 5, 2026

anonrig approved these changes Jan 6, 2026

View reviewed changes

UlisesGascon approved these changes Jan 6, 2026

View reviewed changes

joyeecheung reviewed Jan 6, 2026

View reviewed changes

Hardanish-Singh reviewed Jan 6, 2026

View reviewed changes

lpinca previously approved these changes Jan 7, 2026

View reviewed changes

expose and document loadedModules instead of moduleLoadList

1080338

Xstoudi closed this Jan 9, 2026

Xstoudi mentioned this pull request Jan 9, 2026

lib: add process.loadedModules list #61330

Open


		* Type: {string\[]}

		The `process.moduleLoadList` property returns an array of internal bindings and core modules that

Uh oh!

Conversation

Xstoudi commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 4, 2026

Uh oh!

codecov bot commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

avivkeller commented Jan 5, 2026

Uh oh!

Xstoudi commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

joyeecheung Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Xstoudi Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Xstoudi Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Renegade334 Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

joyeecheung Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

joyeecheung Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Hardanish-Singh Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Hardanish-Singh Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Xstoudi commented Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Xstoudi commented Jan 4, 2026 •

edited

Loading

codecov bot commented Jan 4, 2026 •

edited

Loading

Xstoudi commented Jan 5, 2026 •

edited

Loading

joyeecheung Jan 6, 2026 •

edited

Loading