sqlite: do not silently fail during module initialization

[Renegade334]

Module initialisation steps should crash on failure.

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (fc0952f) to head (707b6ed).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #61265   +/-   ##
=======================================
  Coverage   88.54%   88.55%           
=======================================
  Files         704      704           
  Lines      208753   208750    -3     
  Branches    40279    40280    +1     
=======================================
+ Hits       184844   184850    +6     
+ Misses      15919    15904   -15     
- Partials     7990     7996    +6     

Files with missing lines	Coverage Δ
src/node_sqlite.cc	80.23% <100.00%> (+0.06%)	⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[addaleax]

Can you explain why the JS exception shouldn't be propagated as it normally would? We're frequently doing changes to the codebase to move away from incorrect .ToLocalChecked() calls, but not typicallz the other way around.

[Renegade334]

Can you explain why the JS exception shouldn't be propagated as it normally would?

Checked calls are the norm for all binding initialisers, including the likes of SetMethod() et al. AFAICT this is the only instance across the codebase that doesn't use the pattern.

[addaleax]

@Renegade334 Yeah, I'd say that's something we should fix -- by aligning on proper error handling.