sqlite: db.prepare(sql).set* chain#61263
Conversation
|
Review requested:
|
himself65
left a comment
There was a problem hiding this comment.
Could you please update the test case?
|
I updated all tests with |
There was a problem hiding this comment.
I'm -0.5 on this, as repeated calls across the JS-C++ boundary to set statement options is a very much less efficient paradigm than the alternative proposal, which was to allow options to be passed to prepare(). Passing a consolidated options object to set statement options also matches the pattern already in use in the database constructor.
|
I updated the issue to address this and now recommend |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61263 +/- ##
==========================================
- Coverage 88.54% 88.53% -0.02%
==========================================
Files 704 704
Lines 208753 208757 +4
Branches 40280 40288 +8
==========================================
- Hits 184847 184820 -27
- Misses 15907 15952 +45
+ Partials 7999 7985 -14
🚀 New features to boost your workflow:
|
|
Closing in favor of Proposal 2 |
This implements Proposal 1 of issue #61235