lib: fix phantom EACCES on spawn in some environments#61253
Open
watilde wants to merge 3 commits intonodejs:mainfrom
Open
lib: fix phantom EACCES on spawn in some environments#61253watilde wants to merge 3 commits intonodejs:mainfrom
watilde wants to merge 3 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
child_process
On some Linux environments (e.g. WSL), execvp may return EACCES instead of ENOENT when a command is not found in PATH, if it encounters permission errors during the search. This change adds a check to verify if the file actually exists in PATH when EACCES is received for a command without path separators. If not found, the error is normalized to ENOENT.
Adds a test case that places inaccessible directories and files in PATH to verify that spawn correctly returns ENOENT for non-existent commands, ensuring robustness of the EACCES handling fix.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61253 +/- ##
==========================================
- Coverage 88.53% 88.53% -0.01%
==========================================
Files 704 704
Lines 208736 208775 +39
Branches 40274 40288 +14
==========================================
+ Hits 184810 184836 +26
- Misses 15944 15957 +13
Partials 7982 7982
🚀 New features to boost your workflow:
|
- Use ||= operator in lib/internal/child_process.js - Add descriptive comment to empty catch block in test - Add test cases for non-executable files, empty PATH entries, and missing PATH in envPairs to cover verifyENOENT logic. Fixes: https://github.com/nodejs/node/issues/XXXXX (if applicable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some Linux environments (e.g. WSL), execvp may return EACCES instead of ENOENT when a command is not found in PATH, if it encounters permission errors during the search. This change adds a check to verify if the file actually exists in PATH when EACCES is received for a command without path separators. If not found, the error is normalized to ENOENT.
refs: https://gist.github.com/watilde/db38ff0335834a32a6eebaa6b3373b8b
Once this is merged, I plan to add a CI setup for the WSL Distribution, which I believe will have a fair amount of users.