inspector: fix compressed responses#61226
Closed
rubnogueira wants to merge 5 commits intonodejs:mainfrom
Closed
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http2
Contributor
Author
|
Tagging you @legendecas because I saw some of your work on the inspector. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61226 +/- ##
==========================================
- Coverage 88.54% 88.53% -0.01%
==========================================
Files 704 704
Lines 208734 208866 +132
Branches 40271 40300 +29
==========================================
+ Hits 184823 184927 +104
- Misses 15932 15945 +13
- Partials 7979 7994 +15
🚀 New features to boost your workflow:
|
rubnogueira
changed the title
Contributor
Author
|
I just removed irrelevant code, improved testing/linting, built locally Node binary, and tested against my repro. Rebased first commit message following guidelines. Please let me know if something is missing since it's my first contribution in this repo. |
legendecas
added
commit-queue-squash
Contributor
Author
|
@legendecas can you please review my last changes? thanks! |
legendecas
approved these changes
Jan 14, 2026
legendecas
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
cola119
approved these changes
Jan 17, 2026
Collaborator
legendecas
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61226 ✔ Done loading data for nodejs/node/pull/61226 ----------------------------------- PR info ------------------------------------ Title inspector: fix compressed responses (#61226) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch rubnogueira:main -> nodejs:main Labels http, inspector, http2, author ready, needs-ci, commit-queue-squash Commits 5 - inspector: fix compressed responses - inspector: lint code - inspector: remove irrelevant code - inspector: remove irrelevant file - inspector: fix tests and inline Committers 1 - Ruben Nogueira <ruben.p.nogueira@gmail.com> PR-URL: https://github.com/nodejs/node/pull/61226 Fixes: https://github.com/nodejs/node/issues/61222 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61226 Fixes: https://github.com/nodejs/node/issues/61222 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 30 Dec 2025 20:14:26 GMT ✔ Approvals: 2 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/61226#pullrequestreview-3660965504 ✔ - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/61226#pullrequestreview-3673245165 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2026-01-19T18:02:47Z: https://ci.nodejs.org/job/node-test-pull-request/70893/ - Querying data for job/node-test-pull-request/70893/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/21187587953 |
legendecas
removed
the
commit-queue-failed
Member
|
Landed in 186c7a9 |
aduh95
added
dont-land-on-v20.x
Contributor
|
This PR introduced a flaky test, too bad #61226 (comment) was resumed despite showing the added test failing. I've opened a revert in #61502. |
islandryu
pushed a commit
to islandryu/node
that referenced
this pull request
Jan 25, 2026
PR-URL: nodejs#61226 Fixes: nodejs#61222 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #61222
Using Chrome DevTools inspector tool, the response of the compressed requests is full of garbled symbols.
This PR implements proper compression decryption if the
content-encodingheader is returned in the response headers.Repro here: https://github.com/rubnogueira/nodejs-repro-61222