module: use primordials in helpers.js

[Ayoub-Mabrouk]

Replace native array method (.push) with primordials (ArrayPrototypePush) in lib/internal/modules/helpers.js for consistency and security.

This improves protection against prototype pollution and aligns with the primordials pattern used throughout the codebase.

[nodejs-github-bot]

Review requested:

• @nodejs/loaders

[Renegade334]

For full array prototype coverage here, you'll also need to eliminate the array spreading:

 function initializeCjsConditions() {
   const userConditions = getOptionValue('--conditions');
-  const noAddons = getOptionValue('--no-addons');
-  const addonConditions = noAddons ? [] : ['node-addons'];
   // TODO: Use this set when resolving pkg#exports conditions in loader.js.
-  cjsConditionsArray = [
-    'require',
-    'node',
-    ...addonConditions,
-    ...userConditions,
-  ];
+  cjsConditionsArray = ['require', 'node'];
+  ArrayPrototypePushApply(cjsConditionsArray, userConditions);
+  if (!getOptionValue('--no-addons')) {
+    ArrayPrototypePush(cjsConditionsArray, 'node-addons');
+  }
   if (getOptionValue('--require-module')) {
     ArrayPrototypePush(cjsConditionsArray, 'module-sync');
   }
 }

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (05d6b9b) to head (2a1b012).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61200      +/-   ##
==========================================
- Coverage   88.53%   88.52%   -0.01%     
==========================================
  Files         703      703              
  Lines      208599   208600       +1     
  Branches    40229    40232       +3     
==========================================
- Hits       184685   184667      -18     
- Misses      15939    15951      +12     
- Partials     7975     7982       +7     

Files with missing lines	Coverage Δ
lib/internal/modules/helpers.js	98.17% <100.00%> (+<0.01%)	⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.