v8: use primordials in startup_snapshot.js#61199
Open
Ayoub-Mabrouk wants to merge 1 commit intonodejs:mainfrom
Open
v8: use primordials in startup_snapshot.js#61199Ayoub-Mabrouk wants to merge 1 commit intonodejs:mainfrom
Ayoub-Mabrouk wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61199 +/- ##
==========================================
- Coverage 88.53% 88.53% -0.01%
==========================================
Files 703 703
Lines 208599 208618 +19
Branches 40229 40245 +16
==========================================
+ Hits 184685 184690 +5
- Misses 15939 15949 +10
- Partials 7975 7979 +4
🚀 New features to boost your workflow:
|
Member
|
Please amend your commit to abide by the guidelines |
63cd1b4 to
a60a853
Compare
Replace native methods with primordials.
a60a853 to
00bb902
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace native array methods (.push, .shift) with primordials (ArrayPrototypePush, ArrayPrototypeShift) in lib/internal/v8/startup_snapshot.js for consistency and security.
This improves protection against prototype pollution and aligns with the primordials pattern used throughout the codebase.