url: use ArrayPrototypePush in URLSearchParams methods#61195
Open
Ayoub-Mabrouk wants to merge 1 commit intonodejs:mainfrom
Open
url: use ArrayPrototypePush in URLSearchParams methods#61195Ayoub-Mabrouk wants to merge 1 commit intonodejs:mainfrom
Ayoub-Mabrouk wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
ljharb
approved these changes
Dec 29, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61195 +/- ##
==========================================
- Coverage 88.53% 88.03% -0.51%
==========================================
Files 703 703
Lines 208599 208613 +14
Branches 40229 40164 -65
==========================================
- Hits 184685 183648 -1037
- Misses 15939 16925 +986
- Partials 7975 8040 +65
🚀 New features to boost your workflow:
|
avivkeller
approved these changes
Dec 29, 2025
Member
|
Please amend your commit to abide by the guidelines |
574e617 to
343c6b8
Compare
Replace native methods with primordials.
343c6b8 to
51a3c66
Compare
VoltrexKeyva
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace native array.push() with ArrayPrototypePush in URLSearchParams.getAll() and parseParams() for consistency with the primordials pattern.
This improves security against prototype pollution and aligns with existing patterns in the file.