Skip to content

Conversation

@LiviaMedeiros
Copy link
Member

These methods are already present on Uint8Array, so without defining them on Buffer they return instances of Uint8Array. This introduces wrapper to return instances of Buffer instead.

Fixes: #61146

@LiviaMedeiros LiviaMedeiros added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Dec 23, 2025
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (55600e6) to head (c2f669d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61157      +/-   ##
==========================================
+ Coverage   88.52%   88.54%   +0.02%     
==========================================
  Files         703      703              
  Lines      208589   208617      +28     
  Branches    40226    40223       -3     
==========================================
+ Hits       184650   184721      +71     
+ Misses      15954    15919      -35     
+ Partials     7985     7977       -8     
Files with missing lines Coverage Δ
lib/buffer.js 100.00% <100.00%> (ø)

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buffer Issues and PRs related to the buffer subsystem. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Buffer.fromHex and Buffer.fromBase64 should return Buffer instances

1 participant