tools: only report commit validation failure on Slack#61124
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Dec 21, 2025
Merged
tools: only report commit validation failure on Slack#61124nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
cjihrig
approved these changes
Dec 19, 2025
aduh95
added
the
author ready
Member
|
Instead use using the |
Contributor
Author
What would be the upside of that vs what this PR is doing? |
Member
Using it will make the check appear as successful. Without
|
Contributor
Author
|
One goal of #61050 was to mark the workflow as failure when commit message is invalid (same logic as linter failure shows as a failure) |
meixg
approved these changes
Dec 20, 2025
aduh95
added
the
commit-queue
lpinca
approved these changes
Dec 20, 2025
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 607a741 |
MatricalDefunkt
pushed a commit
to MatricalDefunkt/node
that referenced
this pull request
Dec 22, 2025
PR-URL: nodejs#61124 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
added a commit
that referenced
this pull request
Jan 9, 2026
PR-URL: #61124 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
added a commit
that referenced
this pull request
Jan 12, 2026
PR-URL: #61124 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 13, 2026
PR-URL: #61124 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
added a commit
that referenced
this pull request
Jan 19, 2026
PR-URL: #61124 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
islandryu
pushed a commit
to islandryu/node
that referenced
this pull request
Jan 25, 2026
PR-URL: nodejs#61124 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #61050 (comment)