Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1374,6 +1374,20 @@ ExitCode GenerateAndWriteSnapshotData(const SnapshotData** snapshot_data_ptr,
DCHECK(snapshot_config.builder_script_path.has_value());
const std::string& builder_script =
snapshot_config.builder_script_path.value();

// For the special builder node:generate_default_snapshot_source, generate
// the snapshot as C++ source and write it to snapshot.cc (for testing).
if (builder_script == "node:generate_default_snapshot_source") {
// Reset to empty to generate from scratch.
snapshot_config.builder_script_path = {};
exit_code = node::SnapshotBuilder::GenerateAsSource("snapshot.cc",
args_maybe_patched,
result->exec_args(),
snapshot_config,
true /* use_array_literals */);
return exit_code;
}

// node:embedded_snapshot_main indicates that we are using the
// embedded snapshot and we are not supposed to clean it up.
if (builder_script == "node:embedded_snapshot_main") {
Expand Down
Empty file added test/fixtures/exports.cjs
Empty file.
41 changes: 6 additions & 35 deletions test/parallel/test-snapshot-reproducible.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@
const fs = require('fs');
const assert = require('assert');

// When the test fails this helper can be modified to write outputs
// differently and aid debugging.
function log(line) {
console.log(line);
}

function generateSnapshot() {
tmpdir.refresh();

Expand All @@ -21,7 +15,7 @@
'--random_seed=42',
'--predictable',
'--build-snapshot',
'node:generate_default_snapshot',
'node:generate_default_snapshot_source',
],
{
env: { ...process.env, NODE_DEBUG_NATIVE: 'SNAPSHOT_SERDES' },
Expand All @@ -32,39 +26,16 @@
const lines = output.split('\n');
for (const line of lines) {
if (line.startsWith('0x')) {
log(line);

Check failure on line 29 in test/parallel/test-snapshot-reproducible.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md

'log' is not defined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ Seems like a genuine issue

}
}
},
}
);
const blobPath = tmpdir.resolve('snapshot.blob');
return fs.readFileSync(blobPath);
const outputPath = tmpdir.resolve('snapshot.cc');
return fs.readFileSync(outputPath, 'utf-8').split('\n');
}

const buf1 = generateSnapshot();
const buf2 = generateSnapshot();

const diff = [];
let offset = 0;
const step = 16;
do {
const length = Math.min(buf1.length - offset, step);
const slice1 = buf1.slice(offset, offset + length).toString('hex');
const slice2 = buf2.slice(offset, offset + length).toString('hex');
if (slice1 !== slice2) {
diff.push({ offset: '0x' + (offset).toString(16), slice1, slice2 });
}
offset += length;
} while (offset < buf1.length);

assert.strictEqual(offset, buf1.length);
if (offset < buf2.length) {
const length = Math.min(buf2.length - offset, step);
const slice2 = buf2.slice(offset, offset + length).toString('hex');
diff.push({ offset, slice1: '', slice2 });
offset += length;
} while (offset < buf2.length);

assert.deepStrictEqual(diff, []);
assert.strictEqual(buf1.length, buf2.length);
const source1 = generateSnapshot();
const source2 = generateSnapshot();
assert.deepStrictEqual(source1, source2);
Loading