test_runner: propagate V8 options to child process by pmarchini · Pull Request #60999 · nodejs/node

pmarchini · 2025-12-08T23:35:59Z

This PR should address #60986!

At the moment, this solution doesn't take into account NODE_OPTIONS nor the config file.
In order to support both of them, at least for V8 options defined as kV8Option, changes to GetOptionsAsFlags are required.

They will follow in a follow-up PR.

nodejs-github-bot · 2025-12-08T23:36:05Z

Review requested:

@nodejs/test_runner

codecov · 2025-12-09T00:31:29Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (e28656a) to head (410174c).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60999      +/-   ##
==========================================
+ Coverage   88.51%   88.53%   +0.01%     
==========================================
  Files         703      703              
  Lines      208496   208512      +16     
  Branches    40213    40215       +2     
==========================================
+ Hits       184555   184609      +54     
+ Misses      15955    15948       -7     
+ Partials     7986     7955      -31

Files with missing lines	Coverage Δ
lib/internal/test_runner/runner.js	`92.94% <100.00%> (+0.12%)`	⬆️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

juanarbol

LGTM

atlowChemi · 2025-12-09T05:36:34Z

test/parallel/test-runner-flag-propagation.js

+      const child = spawnSync(
+        process.execPath,
+        [
+          '--allow-natives-syntax',


We don't actually validate this flag made any change. Do we want to pass this?
Maybe instead of calling globalThis.gc() we could check the execArgv inside the test?

You absolutely right! Thanks for the suggestion!

nodejs-github-bot · 2025-12-09T12:33:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70446/

nodejs-github-bot · 2025-12-10T23:36:56Z

Commit Queue failed

- Loading data for nodejs/node/pull/60999
✔  Done loading data for nodejs/node/pull/60999
----------------------------------- PR info ------------------------------------
Title      test_runner: propagate V8 options to child process (#60999)
Author     Pietro Marchini <pietro.marchini94@gmail.com> (@pmarchini)
Branch     pmarchini:issue-60986 -> nodejs:main
Labels     needs-ci, test_runner, lts-watch-v22.x, lts-watch-v24.x
Commits    1
 - test_runner: propagate V8 options to child process
Committers 1
 - Pietro Marchini <pietro.marchini94@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/60999
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/60999
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 08 Dec 2025 23:35:59 GMT
   ✔  Approvals: 6
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/60999#pullrequestreview-3554808102
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/60999#pullrequestreview-3555539052
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/60999#pullrequestreview-3556065594
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/60999#pullrequestreview-3556879192
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/60999#pullrequestreview-3556965246
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/60999#pullrequestreview-3559851497
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2025-12-09T12:33:04Z: https://ci.nodejs.org/job/node-test-pull-request/70446/
- Querying data for job/node-test-pull-request/70446/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/20116762228

PR-URL: nodejs#60999 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>

aduh95 · 2025-12-10T23:49:30Z

Landed in 410174c

PR-URL: #60999 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>

PR-URL: nodejs#60999 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>

pmarchini marked this pull request as ready for review December 8, 2025 23:36

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Dec 8, 2025

juanarbol approved these changes Dec 9, 2025

View reviewed changes

atlowChemi approved these changes Dec 9, 2025

View reviewed changes

marco-ippolito approved these changes Dec 9, 2025

View reviewed changes

benjamingr approved these changes Dec 9, 2025

View reviewed changes

RafaelGSS approved these changes Dec 9, 2025

View reviewed changes

pmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2025

RafaelGSS added lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x labels Dec 9, 2025

JakobJingleheimer approved these changes Dec 9, 2025

View reviewed changes

pmarchini added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 10, 2025

aduh95 force-pushed the issue-60986 branch from 17636f1 to 410174c Compare December 10, 2025 23:48

aduh95 merged commit 410174c into nodejs:main Dec 10, 2025
21 checks passed

jdmarshall mentioned this pull request Dec 21, 2025

chore: add node v25 to test matrix RafaelGSS/bench-node#144

Merged

github-actions bot mentioned this pull request Jan 16, 2026

2026-01-19, Version 25.4.0 (Current) #61400

Merged

github-actions bot mentioned this pull request Feb 3, 2026

2026-02-10, Version 24.13.1 'Krypton' (LTS) #61661

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test_runner: propagate V8 options to child process#60999

test_runner: propagate V8 options to child process#60999
aduh95 merged 1 commit intonodejs:mainfrom
pmarchini:issue-60986

pmarchini commented Dec 8, 2025

Uh oh!

nodejs-github-bot commented Dec 8, 2025

Uh oh!

codecov bot commented Dec 9, 2025 •

edited

Loading

Uh oh!

juanarbol left a comment

Uh oh!

atlowChemi Dec 9, 2025

Uh oh!

pmarchini Dec 9, 2025

Uh oh!

nodejs-github-bot commented Dec 9, 2025

Uh oh!

nodejs-github-bot commented Dec 10, 2025

Uh oh!

Uh oh!

aduh95 commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

pmarchini commented Dec 8, 2025

Uh oh!

nodejs-github-bot commented Dec 8, 2025

Uh oh!

codecov bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

juanarbol left a comment

Choose a reason for hiding this comment

Uh oh!

atlowChemi Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

pmarchini Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Dec 9, 2025

Uh oh!

nodejs-github-bot commented Dec 10, 2025

Uh oh!

Uh oh!

aduh95 commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov bot commented Dec 9, 2025 •

edited

Loading