[v24.x][riscv] Fix check failed in bind_to#60962
Closed
kxxt wants to merge 2 commits intonodejs:v24.x-stagingfrom
Closed
[v24.x][riscv] Fix check failed in bind_to#60962kxxt wants to merge 2 commits intonodejs:v24.x-stagingfrom
kxxt wants to merge 2 commits intonodejs:v24.x-stagingfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
9 tasks
richardlau
approved these changes
Dec 5, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
sxa
approved these changes
Dec 5, 2025
Contributor
Author
|
Probably we should retry the CI. |
Collaborator
Contributor
Author
|
Unfortunately, the aix CI failed again. |
Collaborator
Contributor
Author
|
Could we skip or fix those flaky tests for aix CI instead of infinitely retrying it? (Collected from a few recent failed runs) |
kxxt
force-pushed
the
v24-bind-to-riscv
branch
from
60c872c to
98cbf7d
Compare
Contributor
Author
|
Rebased to fix conflict in |
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Dec 7, 2025
Temporarily disable on riscv64 due to build error with nodejs 24.x. ``` $ react-scripts build (node:54006) [DEP0176] DeprecationWarning: fs.F_OK is deprecated, use fs.constants.F_OK instead (Use `node --trace-deprecation ...` to show where the warning was created) Creating an optimized production build... [...] Fatal error in , line 0 Check failed: (trampoline_pos - fixup_pos) <= kMaxBranchOffset. FailureMessage Object: 0x3f8fbf5168 ----- Native stack trace ----- error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. >>> ERROR: alloy: build failed ``` See also: nodejs/node#60895 nodejs/node#60962
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Dec 7, 2025
Temporarily disable on riscv64 due to build error with nodejs 24.x. ``` $ react-scripts build (node:6884) [DEP0176] DeprecationWarning: fs.F_OK is deprecated, use fs.constants.F_OK instead (Use `node --trace-deprecation ...` to show where the warning was created) Creating an optimized production build... [...] Fatal error in , line 0 Check failed: (trampoline_pos - fixup_pos) <= kMaxBranchOffset. FailureMessage Object: 0x3f91ffb168 ----- Native stack trace ----- error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. >>> ERROR: alloy: build failed ``` See also: nodejs/node#60895 nodejs/node#60962
Member
|
Issue for the AIX failures. I think it's fair to assume these are not related to this PR specifically (and the fix to mark it flaky should be in v24.x-staging now). |
Collaborator
Collaborator
github-actions
bot
removed
the
request-ci
github-actions
bot
added
the
request-ci-failed
Contributor
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - deps: V8: backport bbaae8e36164 ⚠ - deps: V8: cherry-pick 394a8053b59e ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/20029272474 |
Contributor
Author
|
It appears that we got another merge conflict. Let me rebase it. |
Original commit message:
Reland "[riscv] Fix Check failed in bind_to"
This is a reland of commit fdb5de2c741658e94944f2ec1218530e98601c23
Original change's description:
> [riscv] Fix Check failed in bind_to
>
> The trampoline should be emitted before the constant pool.
>
> Bug: 420232092
>
> Change-Id: I3a909b122607e37aca9d8765f28810ec74d5dc0b
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6578135
> Auto-Submit: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
> Cr-Commit-Position: refs/heads/main@{#100480}
Bug: 420232092
Change-Id: I1fac1ed8c349383ef4510abea338b3d695ed57ab
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6595668
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#100745}
Refs: v8/v8@bbaae8e
Co-authored-by: kxxt <rsworktech@outlook.com>
Original commit message:
[riscv] Check trampoline before Constant pool in Release mode
Change-Id: I9645cded9328dabb2c11c7859b998c838b95f97b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6653368
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#100935}
Refs: v8/v8@394a805
kxxt
force-pushed
the
v24-bind-to-riscv
branch
from
98cbf7d to
0a99a89
Compare
richardlau
approved these changes
Dec 8, 2025
richardlau
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
Contributor
Author
|
The CI is green now. |
richardlau
pushed a commit
that referenced
this pull request
Dec 10, 2025
Original commit message:
Reland "[riscv] Fix Check failed in bind_to"
This is a reland of commit fdb5de2c741658e94944f2ec1218530e98601c23
Original change's description:
> [riscv] Fix Check failed in bind_to
>
> The trampoline should be emitted before the constant pool.
>
> Bug: 420232092
>
> Change-Id: I3a909b122607e37aca9d8765f28810ec74d5dc0b
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6578135
> Auto-Submit: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
> Cr-Commit-Position: refs/heads/main@{#100480}
Bug: 420232092
Change-Id: I1fac1ed8c349383ef4510abea338b3d695ed57ab
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6595668
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#100745}
Refs: v8/v8@bbaae8e
Co-authored-by: kxxt <rsworktech@outlook.com>
PR-URL: #60962
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Dec 10, 2025
Original commit message:
[riscv] Check trampoline before Constant pool in Release mode
Change-Id: I9645cded9328dabb2c11c7859b998c838b95f97b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6653368
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#100935}
Refs: v8/v8@394a805
PR-URL: #60962
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Member
|
Landed in 2ac18ce...105fbdd |
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 13, 2026
Original commit message:
Reland "[riscv] Fix Check failed in bind_to"
This is a reland of commit fdb5de2c741658e94944f2ec1218530e98601c23
Original change's description:
> [riscv] Fix Check failed in bind_to
>
> The trampoline should be emitted before the constant pool.
>
> Bug: 420232092
>
> Change-Id: I3a909b122607e37aca9d8765f28810ec74d5dc0b
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6578135
> Auto-Submit: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
> Cr-Commit-Position: refs/heads/main@{#100480}
Bug: 420232092
Change-Id: I1fac1ed8c349383ef4510abea338b3d695ed57ab
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6595668
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#100745}
Refs: v8/v8@bbaae8e
Co-authored-by: kxxt <rsworktech@outlook.com>
PR-URL: #60962
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 13, 2026
Original commit message:
[riscv] Check trampoline before Constant pool in Release mode
Change-Id: I9645cded9328dabb2c11c7859b998c838b95f97b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6653368
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#100935}
Refs: v8/v8@394a805
PR-URL: #60962
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport two V8 commits to fix a crash found while building Adguard Home using webpack riscv-forks/electron#9.
This is only needed for v24.x.
The PR for the main branch(#58746) has missed its opportunity because now v8 version on v25.x and main already contains these fixes.
Close #60895