fix: improve ERR_AMBIGUOUS_MODULE_SYNTAX error message#60949
Closed
ST4RKJR wants to merge 1 commit intonodejs:mainfrom
Closed
fix: improve ERR_AMBIGUOUS_MODULE_SYNTAX error message#60949ST4RKJR wants to merge 1 commit intonodejs:mainfrom
ST4RKJR wants to merge 1 commit intonodejs:mainfrom
Conversation
Dynamically identify the CommonJS global that caused the ambiguity.
Collaborator
|
Review requested:
|
Contributor
|
Tests are not passing, there are conflicts, and the linked issue was closed as resolved. Closing for now, thanks for the PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60949 +/- ##
==========================================
- Coverage 88.51% 88.51% -0.01%
==========================================
Files 703 703
Lines 208405 208405
Branches 40190 40193 +3
==========================================
- Hits 184468 184463 -5
- Misses 15941 15950 +9
+ Partials 7996 7992 -4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the error message for ERR_AMBIGUOUS_MODULE_SYNTAX by dynamically identifying the CommonJS global that caused the ambiguity, instead of hardcoding 'require()'.
Fixes #60322