tools: use open instead of codecs.open in cpplint#60890
Closed
y-okt wants to merge 1 commit intonodejs:mainfrom
Closed
tools: use open instead of codecs.open in cpplint#60890y-okt wants to merge 1 commit intonodejs:mainfrom
y-okt wants to merge 1 commit intonodejs:mainfrom
Conversation
with Python 3.14, codecs.open is deprecated, and thus introduce open instead. Fixes: nodejs#60771
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #60771
The following error is observed with Python 3.14. The reason is that
codecs.open()is deprecated, and we want to useopen()instead.