test: add recursive property accessor test#60871
Open
LiviaMedeiros wants to merge 2 commits intonodejs:mainfrom
Open
test: add recursive property accessor test#60871LiviaMedeiros wants to merge 2 commits intonodejs:mainfrom
LiviaMedeiros wants to merge 2 commits intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60871 +/- ##
==========================================
- Coverage 88.56% 88.55% -0.02%
==========================================
Files 703 703
Lines 208259 208291 +32
Branches 40187 40216 +29
==========================================
+ Hits 184454 184458 +4
- Misses 15812 15846 +34
+ Partials 7993 7987 -6 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from: #58793
Test accessing all properties on builtin modules.
The only allowed error is accessing property on prototype when it is available only on actual instances. These are always
TypeErrors, always onprototype, and either anERR_INVALID_THISor an error without code (typically caused by trying to read private properties in getter).