Skip to content

process: optimize asyncHandledRejections by using FixedQueue#60854

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
gurgunday:promises-fixed-queue
Jan 2, 2026
Merged

process: optimize asyncHandledRejections by using FixedQueue#60854
nodejs-github-bot merged 1 commit intonodejs:mainfrom
gurgunday:promises-fixed-queue

Conversation

@gurgunday
Copy link
Member

@gurgunday gurgunday commented Nov 25, 2025

branch:

./node benchmark/run.js --filter handled-rejections process

process/handled-rejections.js
process/handled-rejections.js n=10000: 237,537.91758393912
process/handled-rejections.js n=50000: 306,685.9060958424
process/handled-rejections.js n=100000: 324,124.4183992467

main:

./node benchmark/run.js --filter handled-rejections process

process/handled-rejections.js
process/handled-rejections.js n=10000: 148,219.51309889948
process/handled-rejections.js n=50000: 42,906.982381963964
process/handled-rejections.js n=100000: 23,234.612142965194

Using a regular Array for a queue that only shifts elements is inefficient due to O(N) time complexity per shift operation. FixedQueue provides O(1) dequeue performance

In the benchmark, to really highlight the effect, I used the --unhandled-rejections=warn flag since it uses the queue even more

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 25, 2025

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Nov 25, 2025
@gurgunday gurgunday added the performance Issues and PRs related to the performance of Node.js. label Nov 25, 2025
juanarbol
juanarbol approved these changes Nov 25, 2025
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Uzlopak
Uzlopak approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (5e677d6) to head (b63ee89).
⚠️ Report is 99 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60854      +/-   ##
==========================================
+ Coverage   88.52%   88.54%   +0.02%     
==========================================
  Files         703      703              
  Lines      208585   208585              
  Branches    40225    40218       -7     
==========================================
+ Hits       184650   184693      +43     
+ Misses      15953    15911      -42     
+ Partials     7982     7981       -1
Files with missing lines Coverage Δ
lib/internal/process/promises.js 100.00% <100.00%> (ø)

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 28, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70335/

@gurgunday gurgunday added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 29, 2025
@aduh95 aduh95 force-pushed the promises-fixed-queue branch from 3b5e9c0 to b63ee89 Compare December 26, 2025 22:55
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 26, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70607/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 30, 2025 •
edited by aduh95
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/70635/
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1778/

@Qard Qard added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 2, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 2, 2026
@nodejs-github-bot nodejs-github-bot merged commit 012bf70 into nodejs:main Jan 2, 2026
62 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 2, 2026

Landed in 012bf70

@gurgunday gurgunday deleted the promises-fixed-queue branch January 2, 2026 14:23
aduh95 pushed a commit that referenced this pull request Jan 9, 2026
@gurgunday @aduh95
process: optimize asyncHandledRejections by using FixedQueue
a5357e7 
PR-URL: #60854
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95 pushed a commit that referenced this pull request Jan 12, 2026
@gurgunday @aduh95
process: optimize asyncHandledRejections by using FixedQueue
40e134f 
PR-URL: #60854
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
RafaelGSS pushed a commit that referenced this pull request Jan 13, 2026
@gurgunday @RafaelGSS
process: optimize asyncHandledRejections by using FixedQueue
f63a8b7 
PR-URL: #60854
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@RafaelGSS
Copy link
Member

RafaelGSS commented Jan 14, 2026 •
edited
Loading

This commit makes test-reproducible-snapshot fail on v25.x-staging. I'll drop it from v25.x-staging and request a manual backport.

cc: @joyeecheung @nodejs/releasers - this might fail on v24 too.

@RafaelGSS RafaelGSS added the backport-requested-v25.x PRs awaiting manual backport to the v25.x-staging branch. label Jan 14, 2026
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 15, 2026
@gurgunday @RafaelGSS
process: optimize asyncHandledRejections by using FixedQueue
96c3ece 
PR-URL: nodejs#60854
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
islandryu pushed a commit to islandryu/node that referenced this pull request Jan 25, 2026
@gurgunday @islandryu
process: optimize asyncHandledRejections by using FixedQueue
f5f0751 
PR-URL: nodejs#60854
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qard Qard Qard approved these changes

@juanarbol juanarbol juanarbol approved these changes

@IlyasShabi IlyasShabi IlyasShabi approved these changes

+1 more reviewer

@Uzlopak Uzlopak Uzlopak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v25.x PRs awaiting manual backport to the v25.x-staging branch. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gurgunday @nodejs-github-bot @RafaelGSS @Qard @Uzlopak @juanarbol @IlyasShabi @mcollina