test: add missing test for empty string in path.posix.normalize()#60823
Closed
cruzz77 wants to merge 1 commit intonodejs:mainfrom
Closed
test: add missing test for empty string in path.posix.normalize()#60823cruzz77 wants to merge 1 commit intonodejs:mainfrom
cruzz77 wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60823 +/- ##
==========================================
- Coverage 88.56% 88.53% -0.03%
==========================================
Files 703 703
Lines 208268 208268
Branches 40175 40171 -4
==========================================
- Hits 184444 184394 -50
- Misses 15828 15874 +46
- Partials 7996 8000 +4 🚀 New features to boost your workflow:
|
Contributor
|
That's already covered by the tests node/test/parallel/test-path-zero-length-strings.js Lines 22 to 23 in 7fe8085 |
Contributor
Author
|
Thank you for pointing that out and for taking the time to review my PR. I totally understand why the PR was closed since this case is already properly tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #60822
Problem
The implementation of
path.posix.normalize()explicitly handles the empty string case:However, the test suite (
test/parallel/test-path-normalize.js) did not include a test for this behavior, leaving this branch untested.Fix
This PR adds the following assertion to ensure the empty path case is properly covered:
Tests