doc,test: remove usage of util.inherits#60817
Open
AugustinMauroy wants to merge 1 commit intonodejs:mainfrom
Open
doc,test: remove usage of util.inherits#60817AugustinMauroy wants to merge 1 commit intonodejs:mainfrom
AugustinMauroy wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60817 +/- ##
==========================================
+ Coverage 88.43% 88.55% +0.11%
==========================================
Files 703 703
Lines 208235 208254 +19
Branches 40085 40159 +74
==========================================
+ Hits 184162 184424 +262
+ Misses 16069 15828 -241
+ Partials 8004 8002 -2 π New features to boost your workflow:
|
anonrig
approved these changes
Nov 23, 2025
Contributor
|
The doc part LGTM, can you remove the test change? IMO we want to validate there are no regressions on legacy APIs |
Member
Author
|
There are a specific test for this api. I had checked that . (I am on mobile I can't give the name of the test file) EDIT: file is |
Contributor
|
I would still prefer the test change gets to be discussed separately |
aymen94
approved these changes
Dec 1, 2025
Contributor
|
@AugustinMauroy can you please split the PR as requested? |
Member
Author
I'm going to do that. kind of busy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description