util: fix parseArgs skipping first positional arg with --eval= and --…#60814

Closed

azadgupta1 wants to merge 1 commit intonodejs:mainfrom

azadgupta1:fix-eval-args

Contributor

azadgupta1 commented Nov 22, 2025

Fix: handle `--eval=` and `--print=` correctly in `getMainArgs()`

Fixes #60808

parseArgs() was skipping the first positional argument when Node was started
with --eval= or --print=. The logic only checked for --eval / --print
and missed the --eval=... / --print=... forms.

This patch adds startsWith('--eval=') and startsWith('--print=') checks so
getMainArgs() returns the correct slice of process.argv.

After this fix, positional arguments are preserved correctly for all eval/print forms.

nodejs-github-bot added needs-ci util labels

IlyasShabi reviewed

View reviewed changes

Member

IlyasShabi left a comment •

edited

Loading

Can you add tests please

Renegade334 reviewed

View reviewed changes

lib/internal/util/parse_args/parse_args.js Outdated Show resolved Hide resolved

codecov bot commented Nov 22, 2025 •

edited

Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (7fd3688) to head (dc3236b).
⚠️ Report is 119 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60814      +/-   ##
==========================================
- Coverage   88.56%   88.53%   -0.03%     
==========================================
  Files         703      703              
  Lines      208254   208425     +171     
  Branches    40156    40197      +41     
==========================================
+ Hits       184430   184537     +107     
- Misses      15828    15893      +65     
+ Partials     7996     7995       -1

Files with missing lines	Coverage Δ
lib/internal/util/parse_args/parse_args.js	`99.26% <100.00%> (-0.01%)`	⬇️

... and 68 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

azadgupta1 force-pushed the fix-eval-args branch 2 times, most recently from bc85468 to 8ed13dc Compare

November 23, 2025 06:39

IlyasShabi reviewed

View reviewed changes

test/parallel/test-parse-args-eval.js Outdated Show resolved Hide resolved

IlyasShabi reviewed

View reviewed changes

test/parallel/test-parse-args-eval.js Outdated Show resolved Hide resolved

Renegade334 requested changes

View reviewed changes

test/parallel/test-parse-args-eval.js Outdated Show resolved Hide resolved

test/parallel/test-parse-args-eval.js Outdated Show resolved Hide resolved

azadgupta1 force-pushed the fix-eval-args branch 2 times, most recently from a89d8c5 to 5919b08 Compare

November 25, 2025 04:10

Renegade334 reviewed

View reviewed changes

test/parallel/test-parse-args.mjs Outdated Show resolved Hide resolved

azadgupta1 force-pushed the fix-eval-args branch from 5919b08 to edb11e6 Compare

November 25, 2025 08:42

Renegade334 approved these changes

View reviewed changes

Member

Renegade334 left a comment

Thanks for this!

Renegade334 added author ready request-ci labels

github-actions bot removed the request-ci label

Contributor Author

azadgupta1 commented Nov 25, 2025

Thanks for the guidance, appreciate it!

Renegade334 added the request-ci label

github-actions bot removed the request-ci label

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Renegade334 requested a review from IlyasShabi

December 1, 2025 00:44

IlyasShabi approved these changes

View reviewed changes

aduh95 reviewed

View reviewed changes

test/parallel/test-parse-args.mjs Outdated Show resolved Hide resolved

shadowspawn reviewed

View reviewed changes

test/parallel/test-parse-args.mjs Show resolved Hide resolved

Member

shadowspawn commented Dec 4, 2025

Nice catch and change. I like checking the internal options instead of doing a pseudo parse of execArgv.

Contributor Author

azadgupta1 commented Dec 7, 2025

Just checking in — let me know if anything else is required from me.

Member

Renegade334 commented Dec 7, 2025

There's #60814 (review) regarding the order of the test assertions, otherwise all good 👍

azadgupta1 force-pushed the fix-eval-args branch 4 times, most recently from f1c2f16 to 20b7b6c Compare

December 8, 2025 11:43


          test: replace process.execArgv parseArgs tests with spawn tests

dc3236b

azadgupta1 force-pushed the fix-eval-args branch from 20b7b6c to dc3236b Compare

December 8, 2025 11:48

Renegade334 approved these changes

View reviewed changes

Renegade334 added the request-ci label

github-actions bot removed the request-ci label

This comment was marked as outdated.

Sign in to view

Collaborator

nodejs-github-bot commented Dec 9, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70459/

Renegade334 pushed a commit to Renegade334/node that referenced this pull request


          util: fix parseArgs skipping positional arg with --eval and --print

060deae

PR-URL: nodejs#60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

Renegade334 closed this

Member

Renegade334 commented Dec 11, 2025

Landed in 060deae

This was referenced Dec 11, 2025

util.parseArgs() omits the first positional argument when used with the --eval= option #60808

Closed

test: check util.parseArgs argv parsing with actual process execution #61089

Merged

nodejs-github-bot pushed a commit that referenced this pull request


          test: check util.parseArgs argv parsing with actual process execution

7b7f693

PR-URL: #61089
Refs: #60814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

aduh95 pushed a commit that referenced this pull request


          util: fix parseArgs skipping positional arg with --eval and --print

22a2270

PR-URL: #60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

aduh95 pushed a commit that referenced this pull request


          test: check util.parseArgs argv parsing with actual process execution

700775d

PR-URL: #61089
Refs: #60814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

aduh95 pushed a commit that referenced this pull request


          util: fix parseArgs skipping positional arg with --eval and --print

1a2d5b7

PR-URL: #60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

aduh95 pushed a commit that referenced this pull request


          test: check util.parseArgs argv parsing with actual process execution

b580f7b

PR-URL: #61089
Refs: #60814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

RafaelGSS pushed a commit that referenced this pull request


          util: fix parseArgs skipping positional arg with --eval and --print

98b6dc1

PR-URL: #60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

RafaelGSS pushed a commit that referenced this pull request


          test: check util.parseArgs argv parsing with actual process execution

c08afc5

PR-URL: #61089
Refs: #60814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

github-actions bot mentioned this pull request

2026-01-19, Version 25.4.0 (Current) #61400

Merged

aduh95 pushed a commit that referenced this pull request


          util: fix parseArgs skipping positional arg with --eval and --print

bb6e680

PR-URL: #60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

aduh95 pushed a commit that referenced this pull request


          test: check util.parseArgs argv parsing with actual process execution

da4d4d4

PR-URL: #61089
Refs: #60814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

islandryu pushed a commit to islandryu/node that referenced this pull request


          util: fix parseArgs skipping positional arg with --eval and --print

33e5117

PR-URL: nodejs#60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

islandryu pushed a commit to islandryu/node that referenced this pull request


          test: check util.parseArgs argv parsing with actual process execution

1516ed1

PR-URL: nodejs#61089
Refs: nodejs#60814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

github-actions bot mentioned this pull request

2026-02-10, Version 24.13.1 'Krypton' (LTS) #61661

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready needs-ci util