[v25.x] lib: do not provide an empty Proxy from localStorage getter#60776
[v25.x] lib: do not provide an empty Proxy from localStorage getter#60776Renegade334 wants to merge 1 commit intonodejs:v25.x-stagingfrom
Conversation
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Landed in c57a40c |
|
c57a40c was removed from the staging branch, though I cannot reopen this PR (probably because the branch has been deleted). |
|
@Renegade334 it’s not exactly equivalent, it should correctly not mark localStorage as enumerable. |
Addresses the original regression in a way that is more consistent with the user experience in v24.x where no storage-related CLI arguments are passed. Access now warns and returns
undefinedin the case where the requisite path is missing.As things stand, the behaviour will revert to exception-raising in v26.x; any discussion relating to this specifically should go in the associated issue, this PR is just to re-fix the regression for localStorage users in v25.
Refs: #60303