tools: update Visual Studio reference to 2022 in install script#60738
Closed
yashwantbezawada wants to merge 1 commit intonodejs:mainfrom
Closed
tools: update Visual Studio reference to 2022 in install script#60738yashwantbezawada wants to merge 1 commit intonodejs:mainfrom
yashwantbezawada wants to merge 1 commit intonodejs:mainfrom
Conversation
The install_tools.bat script displayed an outdated URL reference to visualstudio2019-workload-vctools in the license information, while the actual installation command correctly uses visualstudio2022-workload-vctools. This updates the URL displayed to users to match the package that is actually being installed. Fixes: nodejs#60733
nodejs-github-bot
added
install
Contributor
|
Thanks sorry I did it wrong |
Member
|
Unsolicited takeovers of other users' PRs is considered rather poorly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #60733
Summary
The
install_tools.batscript displayed an outdated URL reference tovisualstudio2019-workload-vctoolsin the license information section, while the actual installation command correctly usesvisualstudio2022-workload-vctools.Changes
tools/msvs/install_tools/install_tools.batto reference the correct Visual Studio 2022 package URL that matches what is actually being installedThis ensures users see accurate information about what packages will be installed when they review the license terms.