src: tag v8 aligned pointer slots with embedder data type tags#60602
src: tag v8 aligned pointer slots with embedder data type tags#60602nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60602 +/- ##
==========================================
- Coverage 88.56% 88.54% -0.03%
==========================================
Files 704 704
Lines 208077 208085 +8
Branches 40084 40082 -2
==========================================
- Hits 184289 184253 -36
- Misses 15826 15867 +41
- Partials 7962 7965 +3
🚀 New features to boost your workflow:
|
joyeecheung
left a comment
There was a problem hiding this comment.
RSLGTM. I feel that it'd be nicer to add a method to BaseObject that allows setting arbitrary slot with the tag so that we don't have to repeat the default argument in all its subclasses, but that can be a followup
Many of the changed lines in this PR are not in the subclasses of |
|
Landed in b8e264d |
|
Build failure on v25.x-staging: |
|
Sorry, it should not land on v25.x |
Fixes: #60589