Skip to content

doc: align Buffer.concat documentation with behavior #60405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Feb 2, 2026
Merged

doc: align Buffer.concat documentation with behavior #60405

nodejs-github-bot merged 1 commit into from
Feb 2, 2026
+17 −1

Conversation

@gurgunday
Copy link
Member

@gurgunday gurgunday commented Oct 25, 2025 •
edited
Loading

Fixes #60400

  • Fixes docs
  • Adds more coverage

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 25, 2025
@gurgunday gurgunday added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. buffer Issues and PRs related to the buffer subsystem. labels Oct 25, 2025
@codecov
Copy link

codecov bot commented Oct 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (637bda0) to head (d1bfbb6).
⚠️ Report is 123 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #60405   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         704      704           
  Lines      208883   208883           
  Branches    40334    40333    -1     
=======================================
+ Hits       184890   184901   +11     
+ Misses      15977    15968    -9     
+ Partials     8016     8014    -2

see 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. and removed test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. labels Oct 27, 2025
@gurgunday @ChALkeR
doc: align Buffer.concat documentation with behavior
d1bfbb6 
Co-authored-by: Сковорода Никита Андреевич <chalkerx@gmail.com>
@gurgunday gurgunday added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2026
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/21203341447

@ChALkeR ChALkeR added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jan 31, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 31, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71145/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 1, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71156/

@gurgunday gurgunday added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2026
@gurgunday gurgunday added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2026
@nodejs-github-bot nodejs-github-bot merged commit c9673b8 into nodejs:main Feb 2, 2026
74 of 76 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 2, 2026

Landed in c9673b8

aduh95 pushed a commit that referenced this pull request Feb 2, 2026
@gurgunday @ChALkeR @aduh95
doc: align Buffer.concat documentation with behavior
3ad4d9b 
Co-authored-by: Сковорода Никита Андреевич <chalkerx@gmail.com>
PR-URL: #60405
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@aduh95 aduh95 mentioned this pull request Feb 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeR ChALkeR ChALkeR approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Buffer.concat documentation is wrong

5 participants

@gurgunday @nodejs-github-bot @ChALkeR @UlisesGascon @aduh95