tools: add benchmark runner to test-shared#60293
Open
aduh95 wants to merge 1 commit intonodejs:mainfrom
Open
Conversation
Collaborator
|
Review requested:
|
Member
|
I would not be very confident running benchmarks on Cloud VMs that we don't know much about. That's why we have dedicated bare metal machines for that in CI. |
Contributor
Author
Do you think we should add a comment about that in the output? This probably goes without saying, but I'm not suggesting we get rid of the bare metal machines, I'm suggesting that as an addition. |
Member
|
Maybe. Something that says only the results of the Jenkins benchmark CI can be used make a decision. |
1231b2a to
3a4fb75
Compare
3a4fb75 to
8fc7899
Compare
Contributor
Author
|
One upside of having something like that: it allows one to validate changes to the Benchmark tooling during a CI lockdown |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of benchmark workflow: https://github.com/aduh95/node/actions/runs/18478104954