Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
/lib/https.js @nodejs/crypto @nodejs/net @nodejs/http
/src/node_http_common* @nodejs/http @nodejs/http2 @nodejs/net
/src/node_http_parser.cc @nodejs/http @nodejs/net
/lib/internal/http/* @nodejs/http @nodejs/net

# http2

Expand Down
7 changes: 5 additions & 2 deletions benchmark/http/check_invalid_header_char.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'use strict';

const common = require('../common.js');
const _checkInvalidHeaderChar = require('_http_common')._checkInvalidHeaderChar;

const groupedInputs = {
// Representative set of inputs from an AcmeAir benchmark run:
Expand Down Expand Up @@ -51,9 +50,13 @@ const inputs = [
const bench = common.createBenchmark(main, {
input: inputs.concat(Object.keys(groupedInputs)),
n: [1e6],
}, {
flags: ['--expose-internals', '--no-warnings'],
});

function main({ n, input }) {
const checkInvalidHeaderChar = require('internal/http/common')._checkInvalidHeaderChar;

let inputs = [input];
if (Object.hasOwn(groupedInputs, input)) {
inputs = groupedInputs[input];
Expand All @@ -62,7 +65,7 @@ function main({ n, input }) {
const len = inputs.length;
bench.start();
for (let i = 0; i < n; i++) {
_checkInvalidHeaderChar(inputs[i % len]);
checkInvalidHeaderChar(inputs[i % len]);
}
bench.end(n);
}
7 changes: 5 additions & 2 deletions benchmark/http/check_is_http_token.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'use strict';

const common = require('../common.js');
const _checkIsHttpToken = require('_http_common')._checkIsHttpToken;

const bench = common.createBenchmark(main, {
key: [
Expand Down Expand Up @@ -38,12 +37,16 @@ const bench = common.createBenchmark(main, {
'alternate-protocol:', // slow bailout
],
n: [1e6],
}, {
flags: ['--expose-internals', '--no-warnings'],
});

function main({ n, key }) {
const checkIsHttpToken = require('internal/http/common')._checkIsHttpToken;

bench.start();
for (let i = 0; i < n; i++) {
_checkIsHttpToken(key);
checkIsHttpToken(key);
}
bench.end(n);
}
2 changes: 1 addition & 1 deletion benchmark/http/set_header.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const common = require('../common.js');
const { OutgoingMessage } = require('_http_outgoing');
const { OutgoingMessage } = require('http');

const bench = common.createBenchmark(main, {
value: [
Expand Down
3 changes: 3 additions & 0 deletions doc/api/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -4329,6 +4329,9 @@ Creating SHAKE-128 and SHAKE-256 digests without an explicit `options.outputLeng

<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/58535
description: Runtime deprecation.
- version:
- v24.6.0
- v22.19.0
Expand Down
Loading
Loading