Slightly improve module deprecation warnings#58442
Closed
dario-piotrowicz wants to merge 2 commits intonodejs:mainfrom
Closed
Slightly improve module deprecation warnings#58442dario-piotrowicz wants to merge 2 commits intonodejs:mainfrom
dario-piotrowicz wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
dario-piotrowicz
added
the
semver-major
nodejs-github-bot
added
lib / src
Member
Author
|
I've added the semver-major label since this PR is making changes to code introduced in #58337 which was under semver-major, so I figured that it probably makes sense to also mark this PR as semver-major (so that it's not going to be applied to old releases with the other changes), please let me know if I'm wrong 🙂 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58442 +/- ##
=======================================
Coverage 90.18% 90.18%
=======================================
Files 635 635
Lines 187224 187224
Branches 36760 36762 +2
=======================================
+ Hits 168850 168851 +1
+ Misses 11139 11126 -13
- Partials 7235 7247 +12
🚀 New features to boost your workflow:
|
anonrig
approved these changes
May 24, 2025
bjohansebas
approved these changes
May 24, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
RaisinTen
added
dont-land-on-v20.x
RaisinTen
approved these changes
May 26, 2025
Member
RaisinTen
left a comment
RaisinTen
left a comment
There was a problem hiding this comment.
Looks good. The dont-land labels are more appropriate than the semver-major label, so I have replaced the label.
Member
Author
Thanks @RaisinTen 🙏 (I did consider using the |
dario-piotrowicz
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in d3bc454...83052ff |
nodejs-github-bot
pushed a commit
that referenced
this pull request
May 26, 2025
PR-URL: #58442 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
May 26, 2025
PR-URL: #58442 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @shivarm I'm adding to all the various module deprecation warnings the suggestion of what alternative module should be used instead, I am also updating the sys warning to refer to
node:utilinstead ofutil.