util: update util.isArray() to eol#58027
util: update util.isArray() to eol#58027miguelmarcondesf wants to merge 4 commits intonodejs:mainfrom
Conversation
|
It seems like there is still some hesitation about doing this - #58013 (comment). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #58027 +/- ##
==========================================
+ Coverage 88.00% 88.51% +0.50%
==========================================
Files 704 704
Lines 208739 208736 -3
Branches 40196 40280 +84
==========================================
+ Hits 183706 184765 +1059
+ Misses 16992 15976 -1016
+ Partials 8041 7995 -46
🚀 New features to boost your workflow:
|
|
I think build is failing because a link to the |
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - util: update util.isArray() to eol ⚠ - Update version change with pr number ⚠ - fix endoflife typo ⚠ - Fix typo from version ⚠ - doc: update deprecation notice for util.isArray() removal ⚠ - doc: remove unused reference to Array.isArray() in util documentation ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14686825918 |
d29f97e to
d819523
Compare
jasnell
left a comment
There was a problem hiding this comment.
I still encounter this API in the wild a fair amount. I'm not all that convinced we should move this one of EOL just yet.
RafaelGSS
left a comment
There was a problem hiding this comment.
+1 Moving this EOL to Node.js 26.
@RafaelGSS Cool, I'll fix the conflicts today |
jasnell
left a comment
There was a problem hiding this comment.
For 26, ok. I still think this one is going to end up a bit more disruptive but that's what semver-major is for.
d819523 to
98d5b07
Compare
|
Let's land it only when v25 goes out. Due to the upcoming V8 update, I might need to sync |
|
Bump this can be updated and merged ? FYI userland migrations had furnished a codemod for this dep |
|
@miguelmarcondesf rebase, please :-) |
98d5b07 to
8640001
Compare
@avivkeller done :-) |
|
Can someone run a CITGM? |
Refs #58013
Update
util.isArrayto eol