src: collapse local var scope in loop#57626
Closed
mertcanaltin wants to merge 3 commits intonodejs:mainfrom
Closed
src: collapse local var scope in loop#57626mertcanaltin wants to merge 3 commits intonodejs:mainfrom
mertcanaltin wants to merge 3 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57626 +/- ##
==========================================
- Coverage 88.54% 88.52% -0.03%
==========================================
Files 703 703
Lines 208545 208545
Branches 40216 40222 +6
==========================================
- Hits 184652 184607 -45
- Misses 15905 15950 +45
Partials 7988 7988
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Mar 28, 2025
Member
addaleax
left a comment
There was a problem hiding this comment.
There's no harm in this, but ideally the commit message would describe the motivation for this change as well, esp. since it is a purely stylistic one
0f15e9d to
426d089
Compare
Member
Author
Thanks, I edited |
Collaborator
anonrig
approved these changes
Jun 25, 2025
Collaborator
Member
Author
|
Thanks for the review. I'm closing this PR because C++ already optimizes local variables, and the new scope is more appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change narrows the scope of local variables to within the loop to improve code clarity and reduce the risk of variable misuse. Although purely stylistic, it helps with maintainability.