Conversation
ooflorent
reviewed
Jan 29, 2022
Contributor
|
Thanks for the new benchmark! Regarding the suite's name, what about Could you fix the formatting? You can automate this using: |
Contributor
Author
|
Ah. Better add |
Contributor
|
I think something weird happened during the rebase 🤔 |
Contributor
Author
|
Fixed the git history, after I nuked it with rebase. Everything should be ok to merge now |
Contributor
|
There is an error in the benchmark: |
dce2cd0 to
5554a19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the new benchmark as suggested by Sander.
They say the hardest problem in programming is naming things.