Skip to content

Comments

Add new benchmark#57

Open
EnderShadow8 wants to merge 9 commits intonoctjs:mainfrom
EnderShadow8:master
Open

Add new benchmark#57
EnderShadow8 wants to merge 9 commits intonoctjs:mainfrom
EnderShadow8:master

Conversation

@EnderShadow8
Copy link
Contributor

I added the new benchmark as suggested by Sander.

They say the hardest problem in programming is naming things.

@ooflorent
Copy link
Contributor

Thanks for the new benchmark! Regarding the suite's name, what about query_stress?

Could you fix the formatting? You can automate this using:

node ./node_modules/.bin/prettier --write 'src/cases/wolf-ecs/*.js'

@EnderShadow8
Copy link
Contributor Author

Ah. Better add .vscode to .gitignore.

@ooflorent
Copy link
Contributor

I think something weird happened during the rebase 🤔

@EnderShadow8
Copy link
Contributor Author

Fixed the git history, after I nuked it with rebase.

Everything should be ok to merge now

@ooflorent
Copy link
Contributor

There is an error in the benchmark:

  query_stress    ERROR
Error: maximum entity limit reached
    at ECS.createEntity (file:///home/runner/work/ecs-benchmark/ecs-benchmark/node_modules/wolf-ecs/wolf-ecs.js:260:23)
    at default (file:///home/runner/work/ecs-benchmark/ecs-benchmark/src/cases/wolf-ecs/query_stress.js:70:19)
    at file:///home/runner/work/ecs-benchmark/ecs-benchmark/src/bench_worker.js:9:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants