Added a new video wallpaper plugin #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
If you want to deprectate the previous mpvpaper plugin, you could just remove most of the code in a new PR, and have a the bar button open a panel with a message to invite people to migrate to the new one. Or just let it live its life :P We dont have a system to deprecate plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new video wallpaper plugin that uses QtMultimedia instead of mpvpaper. This might be a better approach since we wouldn't be dependent on mpvpaper. I'll try to maintain both mpvpaper and this one for now, but in the case that I see that this plugin is more useful than the mpvpaper we can deprecate the mpvpaper plugin.
A lot of this code is taken from the mpvpaper plugin, but still do check the code thorough in case I've missed anything.
@ItsLemmy, would it be possible to deprecate a plugin in the future?