-
Notifications
You must be signed in to change notification settings - Fork 84
Niri color picker plugin added #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
niri-color-picker/Panel.qml
Outdated
| property var screen: null | ||
|
|
||
| // SmartPanel geometry | ||
| readonly property var geometryPlaceholder: panelContainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont need that
niri-color-picker/Panel.qml
Outdated
| } | ||
|
|
||
| Rectangle { | ||
| id: panelContainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove that too
|
Thanks for the PR, can you add a preview image. 16:9 ratio is ideal ex: 960/540 |
|
@ItsLemmy Done. |
|
you should only have one instance or ColorPickerService in main.qml and access it via pluginApi from the bar. |
|
@rscipher001 do you plan on finishing this? |
Disclaimer: Claude Code was used as an assistance for writing this plugin.