[WIP] Support for DTLS #16
Conversation
| :Observe => true, | ||
| :Port => ::CoAP::PORT | ||
| :Port => ::CoAP::PORT, | ||
| :PortDTLS => 5684 # TODO |
There was a problem hiding this comment.
The CoAP gem should support a ::CoAP::PORT_SECURE (or something like that) constant, which it doesn't currently, and that constant should be used instead here.
lib/david/registry.rb
Outdated
|
|
||
| def server | ||
| Celluloid::Actor[:server] | ||
| def server_udp |
There was a problem hiding this comment.
The server_udp and server_dtls functions are only used by the Registry#servers function. They could marked as private or directly integrated into the #servers function. Any preferences on this?
| class CoAPs < Server | ||
| def create_socket(af) | ||
| socket = TinyDTLS::UDPSocket.new(af) | ||
| socket.add_client("foobar", "foobar") |
There was a problem hiding this comment.
Somekind of API is needed to add identity, key pairs for DTLS to david.
| def initialize(socket) | ||
| @log = Celluloid.logger | ||
| @socket = socket || server.socket | ||
| @socket = socket |
There was a problem hiding this comment.
So far I didn't manage to find a function which calls this constructor with nil as an argument. @nning are you aware of any functions which does this?
| begin | ||
| Celluloid::Actor[:server].run | ||
| if options[:DTLS] == 'true' | ||
| Celluloid::Actor[:server_dtls].async.run |
There was a problem hiding this comment.
The David::Server#run runs an infinite loop and since we want to start two servers here the dtls server is started as async.run in the background not sure if that's really a good idea though.
|
|
||
| def log | ||
| @log ||= server.log | ||
| @log ||= Celluloid.logger |
There was a problem hiding this comment.
Since we have two servers now I simply used the Celluoid logger here. Not sure if thats's a good idea though.
|
I didn't touch the test suite yet thus it obviously fails because it tries to initialize a |
|
The commits I pushed a few minutes ago made the necessary changes to the test suite and also include a commit which ensures that the entire gem still works without tinydtls. |
|
|
||
| gemspec | ||
|
|
||
| group :dtls do |
There was a problem hiding this comment.
The file lib/david.rb contains the following lines:
require 'bundler/setup'
Bundler.require(:default, :cbor)Should I add Bundler.require(:default, :dtls) to that file as well?
Currently it is not possible to enable both CoAP und CoAPs at the same time. Doing so would require starting multiple instance of all other celluloid actors (observe, garbage collector, …). Alternatively we could extend this actors in a way that they perform all operations on both servers. The support is implemented by implementing two different server classes which extend the David::Server class: 1. David::Server::CoAP for doing CoAP over UDP 2. David::Server::CoAPs for doing CoAP over DTLS This required some namespacing changes since the CoAP gem can now no longer be addressed as CoAP::<...>. This seems to be the preferred way of implementing multi protocol servers with celluloid. Since this approach was also used for the reel web server: https://github.com/celluloid/reel/wiki/Multi-Protocol-Server
2 participants
These commits add support for DTLS to david. Meaning we can now use CoAP over DTLS.
DTLS itself was implemented using the tinydtls rubygem which was also written by myself. The gem is currently far from finished but works good enough to integrate it into david. The gem itself is simply a wrapper for the tinydtls C library but currently requires a few patches to that library. I am working with the tinydtls maintainer to change that.
Regarding the integration into david, I followed the multi protocol server structure used by the celluloid HTTP server (reel).
Design decisions are further documented in the commit messages but basically this introduces two new
David::Serverclasses: One for CoAP and one for CoAPs. Other celluloid actors (e.g. the garbage collector) had to be adjusted to perform their operations on both of these new server objects.Currently dual stack is supported meaning CoAP and CoAPs can be used at the same time. The CoAPs server is entirely optional though and disabled by default.
A few thing still need be done regarding the integration into david. I will point those out using inline comments. Besides I need to test this further, so for I have only done tests using the provided
config.rufile.CC: @obgm