Skip to content

Move python bindings from pybind11 to nanobind [ci build] #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmwsharp merged 4 commits into from
Dec 25, 2025
Merged

Move python bindings from pybind11 to nanobind [ci build] #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a6e3dc
update ps to latest
nmwsharp Dec 24, 2025
1751b74
update eigen
nmwsharp Dec 25, 2025
df10ed3
core nanobind switchover completed, tests pass locally
nmwsharp Dec 25, 2025
11999a7
update some comments
nmwsharp Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
[submodule "deps/pybind11"]
path = deps/pybind11
url = https://github.com/pybind/pybind11.git
[submodule "deps/polyscope"]
path = deps/polyscope
url = https://github.com/nmwsharp/polyscope.git
[submodule "deps/eigen"]
path = deps/eigen
url = https://gitlab.com/libeigen/eigen.git
[submodule "deps/nanobind"]
path = deps/nanobind
url = https://github.com/wjakob/nanobind
32 changes: 25 additions & 7 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,37 @@
cmake_minimum_required(VERSION 3.15.0) # minimum imposed by scikit-build-core
project(polyscope LANGUAGES CXX)

# Default to release build
if (NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
set(CMAKE_BUILD_TYPE Release CACHE STRING "Choose the type of build." FORCE)
set_property(CACHE CMAKE_BUILD_TYPE PROPERTY STRINGS "Debug" "Release" "MinSizeRel" "RelWithDebInfo")
endif()

set(CMAKE_POSITION_INDEPENDENT_CODE ON)
set(CMAKE_CXX_STANDARD 20)

## Gather dependencies

# Eigen
# == Eigen
set(EIGEN3_INCLUDE_DIR "${PROJECT_SOURCE_DIR}/deps/eigen/")

# Recurse in to pybind
set(PYBIND11_NEWPYTHON ON)
add_subdirectory(deps/pybind11)
# == Nanobind
if (CMAKE_VERSION VERSION_LESS 3.18)
set(DEV_MODULE Development)
else()
set(DEV_MODULE Development.Module)
endif()

# We need polyscope
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
# find python version to target for bindings
find_package(Python 3.9 COMPONENTS Interpreter ${DEV_MODULE} REQUIRED)

# recurse into nanobind
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/deps/nanobind)

# == polyscope
add_subdirectory(deps/polyscope)

pybind11_add_module(polyscope_bindings
nanobind_add_module(polyscope_bindings
src/cpp/core.cpp
src/cpp/surface_mesh.cpp
src/cpp/point_cloud.cpp
Expand All @@ -25,6 +42,7 @@ pybind11_add_module(polyscope_bindings
src/cpp/floating_quantities.cpp
src/cpp/implicit_helpers.cpp
src/cpp/managed_buffer.cpp

src/cpp/imgui.cpp
src/cpp/implot.cpp

Expand Down
2 changes: 1 addition & 1 deletion deps/eigen
Open in desktop
Submodule eigen updated from 4fd5d1 to d71c30
1 change: 1 addition & 0 deletions deps/nanobind
Open in desktop
Submodule nanobind added at c5a3a3
2 changes: 1 addition & 1 deletion deps/polyscope
Open in desktop
Submodule polyscope updated 11 files
+4 −0 include/polyscope/render/engine.h
+4 −0 include/polyscope/render/mock_opengl/mock_gl_engine.h
+4 −0 include/polyscope/render/opengl/gl_engine.h
+2 −1 include/polyscope/vector_quantity.ipp
+1 −5 src/camera_view.cpp
+45 −0 src/render/mock_opengl/mock_gl_engine.cpp
+48 −0 src/render/opengl/gl_engine.cpp
+4 −20 src/surface_mesh.cpp
+4 −4 src/volume_grid_scalar_quantity.cpp
+1 −6 src/volume_mesh.cpp
+69 −21 test/src/volume_grid_test.cpp
1 change: 0 additions & 1 deletion deps/pybind11
Open in desktop
Submodule pybind11 deleted from a2e59f
14 changes: 3 additions & 11 deletions src/cpp/camera_view.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,12 @@
#include <pybind11/eigen.h>
#include <pybind11/numpy.h>
#include <pybind11/pybind11.h>

#include "Eigen/Dense"

#include "polyscope/camera_view.h"
#include "polyscope/polyscope.h"

#include "utils.h"

namespace py = pybind11;
namespace ps = polyscope;


// clang-format off
void bind_camera_view(py::module& m) {
void bind_camera_view(nb::module_& m) {

// == Helper quantity classes

Expand All @@ -40,9 +32,9 @@ void bind_camera_view(py::module& m) {

// Static adders and getters
m.def("register_camera_view", &ps::registerCameraView,
py::arg("name"), py::arg("parameters"), "Register a camera view", py::return_value_policy::reference);
nb::arg("name"), nb::arg("parameters"), "Register a camera view", nb::rv_policy::reference);
m.def("remove_camera_view", &ps::removeCameraView, "Remove a camera view by name");
m.def("get_camera_view", &ps::getCameraView, "Get a camera view by name", py::return_value_policy::reference);
m.def("get_camera_view", &ps::getCameraView, "Get a camera view by name", nb::rv_policy::reference);
m.def("has_camera_view", &ps::hasCameraView, "Check for a camera view by name");

}
Expand Down
Loading
Loading