Skip to content

Conversation

@MiniDigger
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

fixes an broken link on the docs.
maybe https://github.com/unjs/undocs should include https://nuxtseo.com/docs/link-checker/ to prevent this in the future.
I ran nuxt link checker on this repo and it didnt find anything else.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@MiniDigger MiniDigger requested a review from pi0 as a code owner January 31, 2026 11:45
@vercel
Copy link

vercel bot commented Jan 31, 2026

@MiniDigger is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Jan 31, 2026

πŸ“ Walkthrough

Walkthrough

Updated a hyperlink in the Renderer documentation, changing the target from /docs/architecture#request-lifecycle to /docs/lifecycle. This is a documentation reference update with no impact on code or runtime behavior.

Changes

Cohort / File(s) Summary
Documentation Link Update
docs/1.docs/4.renderer.md
Modified read-more link target to point to a different documentation page.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

πŸš₯ Pre-merge checks | βœ… 3
βœ… Passed checks (3 passed)
Check name Status Explanation
Title check βœ… Passed The PR title 'docs: fix lifecycle link on renderer page' follows conventional commits format with a 'docs' scope and clear description of the documentation fix.
Description check βœ… Passed The PR description is related to the changeset, explaining that it fixes a broken link on the renderer docs page and includes context about running a link checker.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 31, 2026

Open in StackBlitz

npm i https://pkg.pr.new/nitrojs/nitro@3992

commit: 443f8f9

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thnx ❀️

@pi0 pi0 merged commit 8aa7b23 into nitrojs:main Jan 31, 2026
10 of 11 checks passed
@pi0
Copy link
Member

pi0 commented Jan 31, 2026

maybe unjs/undocs should include nuxtseo.com/docs/link-checker to prevent this in the future.

@MiniDigger also PR welcome! I guess we had it long before but was very slow. might be better now. (Also undocs disables fail on prerender error, we might enable it back, all ancient reasons)

@MiniDigger MiniDigger deleted the fix-link branch January 31, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants