refactor: separate Spotlight into standalone extension#33
refactor: separate Spotlight into standalone extension#33nisargkolhe wants to merge 1 commit intomainfrom
Conversation
- Create new Arcify Spotlight extension with independent codebase - Remove all Spotlight code from main Arcify extension - Arcify Spotlight has its own settings (accent color, debug logging) - Arcify new tab button now opens chrome://newtab/ directly - Remove spotlight-related permissions from Arcify manifest - Update build configuration to remove spotlight build steps The new Arcify Spotlight extension: - Located at ../arcify-spotlight/ - Has its own manifest, background script, options page - Independent keyboard shortcuts (Alt+L, Alt+T) - No shared code with Arcify - Removed PINNED_TAB feature (Arcify-specific)
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| "installation-onboarding.js", | ||
| "assets/*", | ||
| "_favicon/*", | ||
| "spotlight/shared/*" |
There was a problem hiding this comment.
Onboarding references removed Spotlight commands and settings
High Severity
The toggleSpotlight and toggleSpotlightNewTab commands were removed from the manifest, and the enableSpotlight setting was removed from options, but the installation-onboarding.js and installation-onboarding.html still reference these. The onboarding flow has an entire step dedicated to Spotlight with a toggle button (spotlightToggle), displays keyboard shortcuts for non-existent commands, and saves/loads the now-defunct enableSpotlight setting. Users will see a Spotlight configuration step for a feature that no longer exists, and the displayed shortcuts (Alt+L, Alt+T) won't work.
The new Arcify Spotlight extension:
Note
Separates Spotlight from the main extension by fully removing in-repo Spotlight functionality and wiring.
spotlight/*), new tab override, and related message handling/shortcuts frombackground.jssearch,topSites,historypermissions; removeschrome_url_overrides.newtab, Spotlight commands, and content_scripts; trims web accessible resourcesnewTabBtnnow opens a blank tab; removesenableSpotlightoption and its persistenceWritten by Cursor Bugbot for commit bfa93af. This will update automatically on new commits. Configure here.