Skip to content

Enhancement: Migrate tests to newer PHPUnit versions #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikic merged 1 commit into from
Mar 26, 2019
Merged

Enhancement: Migrate tests to newer PHPUnit versions #72

nikic merged 1 commit into from
Mar 26, 2019

Conversation

@localheinz
Copy link
Contributor

@localheinz localheinz commented Aug 9, 2018

This PR

  • migrates to using newer (and often better) PHPUnit version features

Follows #67 (comment).

💁‍♂️ I ran

$ composer global require friendsofphp/php-cs-fixer

followed by

$ php-cs-fixer fix test --allow-risky yes --rules=@PHPUnit60Migration:risky,no_empty_phpdoc

/cc @jankramer

@nikic nikic merged commit 9abe4e5 into nikic:master Mar 26, 2019
@localheinz localheinz deleted the feature/phpunit branch March 26, 2019 19:59
@localheinz
Copy link
Contributor Author

localheinz commented Mar 26, 2019

Thank you, @nikic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danizord danizord danizord approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@localheinz @danizord @nikic