-
Notifications
You must be signed in to change notification settings - Fork 0
add cfde-opportunity-numbers fetcher #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should close Add function to return CFDE funding opportunity numbers #16.
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new utility to scrape CFDE funding opportunity numbers, along with associated tests and documentation.
- Implements
cfde_opportunity_numbers()function - Adds unit tests for return type and pattern matching
- Provides man page and updates NAMESPACE to export/import the new function
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| R/cfde_opportunity_numbers.R | Implements the HTML scraping logic to extract opportunity numbers |
| man/cfde_opportunity_numbers.Rd | Adds Rd documentation for cfde_opportunity_numbers() |
| tests/testthat/test_cfde_opportunity_numbers.R | Adds tests verifying output type and pattern matching |
| NAMESPACE | Exports the new function and imports necessary rvest functions |
Comments suppressed due to low confidence (2)
tests/testthat/test_cfde_opportunity_numbers.R:1
- [nitpick] Currently there are no tests covering the
urlparameter behavior (e.g., custom URLs or error handling). Consider adding tests for non-default URLs or simulating missing elements to improve coverage.
test_that("cfde_opportunity_numbers returns a character vector", {
NAMESPACE:39
- [nitpick] Since the code uses
rvest::prefixes, these manualimportFrom(rvest,…)entries are redundant. Either remove the imports or switch to unqualified calls for consistency.
importFrom(rvest,html_attr)
Avoid returning NAs since those are not valuable.... Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
the-mayer
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds: