Seed Lua's number generator on nginx worker init#7
Open
quinox wants to merge 1 commit intonigma:masterfrom
Open
Seed Lua's number generator on nginx worker init#7quinox wants to merge 1 commit intonigma:masterfrom
quinox wants to merge 1 commit intonigma:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During testing I discovered Lua doesn't seed itself, resulting in the same request IDs showing in my logs. I've implemented seeding for Unix-like systems using
/dev/urandom; Lots of pages on the internet suggestos.time()but this seems like it would make different nginx workers seed with the same number which is undesirable (but I'm no expert, so I could be wrong).