merge

.github/workflows/github-actions-demo.yml

@@ -0,0 +1,17 @@
+name: GitHub Actions Demo
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+  workflow_dispatch:
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Run JUnit Tests
+        run: |
+          javac -cp .:lib/junit-4.13.2.jar:lib/hamcrest-core-1.3.jar MarkdownParseTest.java
+          java -cp .:lib/junit-4.13.2.jar:lib/hamcrest-core-1.3.jar org.junit.runner.JUnitCore MarkdownParseTest
+

.gitignore

@@ -11,7 +11,6 @@
 .mtj.tmp/
 
 # Package Files #
-*.jar
 *.war
 *.nar
 *.ear

MarkdownParse.java

@@ -12,13 +12,42 @@ public static ArrayList<String> getLinks(String markdown) {
         // find the next [, then find the ], then find the (, then read link upto next )
         int currentIndex = 0;
         while(currentIndex < markdown.length()) {
-            int openBracket = markdown.indexOf("[", currentIndex);
+            int openBracket = markdown.indexOf("[", currentIndex); 
+            if (openBracket == -1) {
+                break;
+            }
+
+            //Checks if there is an "!" that denotes an image link before the open bracket and ends the loop if there is.
+
+            if (openBracket != 0) {
+                if (markdown.substring(openBracket - 1, openBracket).equals("!")) {
+                    currentIndex = openBracket + 1;
+                    continue;
+                }
+            }
+
             int closeBracket = markdown.indexOf("]", openBracket);
+            if (closeBracket == -1) {
+                break;
+            }
             int openParen = markdown.indexOf("(", closeBracket);
+
+            if (openParen == -1 || openParen != closeBracket + 1) {
+                break;
+            }
+
             int closeParen = markdown.indexOf(")", openParen);
+
+
+            if (closeParen == -1) {
+                break;
+            }
+
             toReturn.add(markdown.substring(openParen + 1, closeParen));
+
             currentIndex = closeParen + 1;
         }
+        //41, 67
 
         return toReturn;
     }

MarkdownParseTest.java

@@ -0,0 +1,108 @@
+import java.util.ArrayList;
+import java.io.IOException;
+import java.nio.file.Path;
+import java.nio.file.Files;
+import static org.junit.Assert.*;
+import org.junit.*;
+import java.util.List;
+
+public class MarkdownParseTest {
+    @Test
+    public void addition() {
+        assertEquals(2, 1 + 1);
+    }
+    @Test
+    public void testFile() throws IOException {
+        Path fileName = Path.of("./test-file.md");
+        String content = Files.readString(fileName);
+        ArrayList<String> links = MarkdownParse.getLinks(content);
+        assertEquals(List.of("https://something.com", "some-thing.html"), links);
+    }
+
+    @Test
+    public void testFile2() throws IOException {
+        Path fileName = Path.of("./test-file2.md");
+        String content = Files.readString(fileName);
+        ArrayList<String> links = MarkdownParse.getLinks(content);
+        assertEquals(List.of("https://something.com", "some-thing.html"), links);
+    }
+
+    @Test
+    public void testFile3() throws IOException {
+        Path fileName = Path.of("./test-file3.md");
+        String content = Files.readString(fileName);
+        ArrayList<String> links = MarkdownParse.getLinks(content);
+        assertEquals(List.of("https://something.com", "some-thing.html"), links);
+    }
+
+    @Test
+    public void testFile4() throws IOException {
+        Path fileName = Path.of("./test-file4.md");
+        String content = Files.readString(fileName);
+        ArrayList<String> links = MarkdownParse.getLinks(content);
+        assertEquals(List.of("https://something.com", "some-thing.html"), links);
+    }
+
+    @Test
+    public void testFiles2() throws IOException {
+        Path fileName = Path.of("./testfiles/test-file2.md");
+        String content = Files.readString(fileName);
+        ArrayList<String> links = MarkdownParse.getLinks(content);
+        assertEquals(List.of("https://something.com", "some-page.html"), links);
+    }
+
+    @Test
+    public void testFiles3() throws IOException {
+        Path fileName = Path.of("./testfiles/test-file3.md");
+        String content = Files.readString(fileName);
+        ArrayList<String> links = MarkdownParse.getLinks(content);
+        assertEquals(List.of(), links);
+    }
+
+    @Test
+    public void testFiles4() throws IOException {
+        Path fileName = Path.of("./testfiles/test-file4.md");
+        String content = Files.readString(fileName);
+        ArrayList<String> links = MarkdownParse.getLinks(content);
+        assertEquals(List.of(), links);
+    }
+
+    @Test
+    public void testFiles5() throws IOException {
+        Path fileName = Path.of("./testfiles/test-file5.md");
+        String content = Files.readString(fileName);
+        ArrayList<String> links = MarkdownParse.getLinks(content);
+        assertEquals(List.of(), links);
+    }
+
+    @Test
+    public void testFiles6() throws IOException {
+        Path fileName = Path.of("./testfiles/test-file6.md");
+        String content = Files.readString(fileName);
+        ArrayList<String> links = MarkdownParse.getLinks(content);
+        assertEquals(List.of(), links);
+    }
+
+    @Test
+    public void testFiles7() throws IOException {
+        Path fileName = Path.of("./testfiles/test-file7.md");
+        String content = Files.readString(fileName);
+        ArrayList<String> links = MarkdownParse.getLinks(content);
+        assertEquals(List.of(), links);
+    }
+
+    @Test
+    public void testFiles8() throws IOException {
+        Path fileName = Path.of("./testfiles/test-file8.md");
+        String content = Files.readString(fileName);
+        ArrayList<String> links = MarkdownParse.getLinks(content);
+        assertEquals(List.of("a link on the first line"), links);
+    }
+    @Test
+    public void fileNotHere() throws IOException {
+        Path fileName = Path.of("./testfiles/test-file9.md");
+        String content = Files.readString(fileName);
+        ArrayList<String> links = MarkdownParse.getLinks(content);
+        assertEquals(List.of(), links);
+    }
+}

test-file2.md

@@ -0,0 +1,5 @@
+#Title
+
+![image](invalid)
+[link1](https://something.com)
+[link2](some-thing.html) salad

test-file3.md

@@ -0,0 +1,4 @@
+# Title
+
+[link1](https://something.com)
+[link2](some-thing.html) [ n

test-file4.md

@@ -0,0 +1,7 @@
+# Title
+
+[link1](https://something.com)
+[link2](some-thing.html)
+[
+
+](onomotopoeia

testfiles/test-file2.md

@@ -0,0 +1,6 @@
+# Title
+
+[a link!](https://something.com)
+[another link!](some-page.html)
+
+some paragraph text after the links

testfiles/test-file3.md

@@ -0,0 +1,5 @@
+# title
+
+[]
+
+more text here

testfiles/test-file4.md

@@ -0,0 +1,3 @@
+# title
+
+[]link goes here!

testfiles/test-file5.md

@@ -0,0 +1,7 @@
+# title
+
+[stuff]
+
+paragraph
+
+(page.com)

testfiles/test-file6.md

@@ -0,0 +1,3 @@
+# title 
+
+![link](page.com)

testfiles/test-file7.md

@@ -0,0 +1 @@
+)[

testfiles/test-file8.md

@@ -0,0 +1,2 @@
+[](a link on the first line)
+[