fix(tmux) Added extra ways of preventing hanging opencode instances#172
Open
Megatherium wants to merge 1 commit intonickjvandyke:mainfrom
Open
fix(tmux) Added extra ways of preventing hanging opencode instances#172Megatherium wants to merge 1 commit intonickjvandyke:mainfrom
Megatherium wants to merge 1 commit intonickjvandyke:mainfrom
Conversation
1. By trimming the return value of `tmux split-window` we ensure that no newline gets added to self.pane_id which always has the potential for weird behaviour 2. We're basically "doubly killing" the opencode pane now by first retrieving his PID. Should `tmux kill-pane` somehow fail an immediate `kill` should do the trick. 3. By moving the autocmd from VimLeave to VimLeavePre the command actually fires in case of a e.g. :q!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By trimming the return value of
tmux split-windowwe ensure that no newline gets added to self.pane_id which always has the potential for weird behaviourWe're basically "doubly killing" the opencode pane now by first retrieving his PID. Should
tmux kill-panesomehow fail an immediatekillshould do the trick.By moving the autocmd from VimLeave to VimLeavePre the command actually fires in case of a e.g. :q!
Description
When having an opencode instance running and you quit out with :q! (before you quit the opencode instance via e.g. Ctrl+c), you are left with an orphaned process that at the same time prevents the spawning of OC instances in ANY nvim instance (with the message "Response decode error: Not Found; Vim:E474: Unidentified byte: Not Found"
Related Issue(s)
#118